qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: martin@schrodt.org, maxehr@umiacs.umd.edu,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v4 5/5] audio/hda: enable new timer code by default.
Date: Fri, 22 Jun 2018 13:12:00 +0200	[thread overview]
Message-ID: <20180622111200.30561-6-kraxel@redhat.com> (raw)
In-Reply-To: <20180622111200.30561-1-kraxel@redhat.com>

Also add a compat property to disable it for old machine types,
needed for live migration compatibility.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 include/hw/compat.h  | 4 ++++
 hw/audio/hda-codec.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/hw/compat.h b/include/hw/compat.h
index 563908b874..44d5964060 100644
--- a/include/hw/compat.h
+++ b/include/hw/compat.h
@@ -6,6 +6,10 @@
         .driver   = "migration",\
         .property = "decompress-error-check",\
         .value    = "off",\
+    },{\
+        .driver   = "hda-audio",\
+        .property = "use-timer",\
+        .value    = "false",\
     },
 
 #define HW_COMPAT_2_11 \
diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
index ac67b9aada..fc4945086b 100644
--- a/hw/audio/hda-codec.c
+++ b/hw/audio/hda-codec.c
@@ -839,7 +839,7 @@ static const VMStateDescription vmstate_hda_audio = {
 static Property hda_audio_properties[] = {
     DEFINE_PROP_UINT32("debug", HDAAudioState, debug,   0),
     DEFINE_PROP_BOOL("mixer", HDAAudioState, mixer,  true),
-    DEFINE_PROP_BOOL("use-timer", HDAAudioState, use_timer, false),
+    DEFINE_PROP_BOOL("use-timer", HDAAudioState, use_timer,  true),
     DEFINE_PROP_END_OF_LIST(),
 };
 
-- 
2.9.3

      parent reply	other threads:[~2018-06-22 11:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 11:11 [Qemu-devel] [PATCH v4 0/5] audio/hda: improve windows guest audio quality Gerd Hoffmann
2018-06-22 11:11 ` [Qemu-devel] [PATCH v4 1/5] audio/hda: create millisecond timers that handle IO Gerd Hoffmann
2018-06-22 11:11 ` [Qemu-devel] [PATCH v4 2/5] audio/hda: turn some dprintfs into trace points Gerd Hoffmann
2018-06-24  4:14   ` Philippe Mathieu-Daudé
2018-06-22 11:11 ` [Qemu-devel] [PATCH v4 3/5] audio/hda: tweak timer adjust logic Gerd Hoffmann
2018-06-22 11:11 ` [Qemu-devel] [PATCH v4 4/5] audio/hda: detect output buffer overruns Gerd Hoffmann
2018-06-22 11:12 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180622111200.30561-6-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=martin@schrodt.org \
    --cc=maxehr@umiacs.umd.edu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).