qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 03/28] target-arm: fix a segmentation fault due to illegal memory access
Date: Fri, 22 Jun 2018 13:56:48 +0100	[thread overview]
Message-ID: <20180622125713.15303-4-peter.maydell@linaro.org> (raw)
In-Reply-To: <20180622125713.15303-1-peter.maydell@linaro.org>

From: Zheng Xiang <xiang.zheng@linaro.org>

The elements of kvm_devices_head list are freed in kvm_arm_machine_init_done(),
but we still access these illegal memory in kvm_arm_devlistener_del().

This will cause segment fault when booting guest with MALLOC_PERTURB_=1.

Signed-off-by: Zheng Xiang <xiang.zheng@linaro.org>
Message-id: 20180619075821.9884-1-zhengxiang9@huawei.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/kvm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/arm/kvm.c b/target/arm/kvm.c
index 98f50063238..5bf41e151c6 100644
--- a/target/arm/kvm.c
+++ b/target/arm/kvm.c
@@ -256,6 +256,7 @@ static void kvm_arm_machine_init_done(Notifier *notifier, void *data)
             kvm_arm_set_device_addr(kd);
         }
         memory_region_unref(kd->mr);
+        QSLIST_REMOVE_HEAD(&kvm_devices_head, entries);
         g_free(kd);
     }
     memory_listener_unregister(&devlistener);
-- 
2.17.1

  parent reply	other threads:[~2018-06-22 12:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 12:56 [Qemu-devel] [PULL 00/28] target-arm queue Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 01/28] hw/intc/arm_gicv3: fix an extra left-shift when reading IPRIORITYR Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 02/28] target/arm: Minor cleanup for ARMv6-M 32-bit instructions Peter Maydell
2018-06-22 12:56 ` Peter Maydell [this message]
2018-06-22 12:56 ` [Qemu-devel] [PULL 04/28] linux-headers: Update to kernel mainline commit b357bf602 Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 05/28] target/arm: Allow KVM device address overwriting Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 06/28] hw/intc/arm_gicv3: Introduce redist-region-count array property Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 07/28] hw/intc/arm_gicv3_kvm: Get prepared to handle multiple redist regions Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 08/28] hw/arm/virt: GICv3 DT node with one or two redistributor regions Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 09/28] hw/arm/virt-acpi-build: Advertise one or two GICR structures Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 10/28] hw/arm/virt: Register two redistributor regions when necessary Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 11/28] hw/arm/virt: Add a new 256MB ECAM region Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 12/28] hw/arm/virt: Add virt-3.0 machine type Peter Maydell
2018-06-22 12:56 ` [Qemu-devel] [PULL 13/28] hw/arm/virt: Use 256MB ECAM region by default Peter Maydell
2024-01-08 15:52   ` Peter Maydell
2024-01-08 17:20     ` Eric Auger
2018-06-22 12:56 ` [Qemu-devel] [PULL 14/28] hw/arm/virt: Increase max_cpus to 512 Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 15/28] target-arm: Add the Cortex-R5F Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 16/28] xlnx-zynqmp: Swap Cortex-R5 for Cortex-R5F Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 17/28] hw/misc/tz-mpc.c: Implement the Arm TrustZone Memory Protection Controller Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 18/28] hw/misc/tz-mpc.c: Implement registers Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 19/28] hw/misc/tz-mpc.c: Implement correct blocked-access behaviour Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 20/28] hw/misc/tz_mpc.c: Honour the BLK_LUT settings in translate Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 21/28] hw/misc/iotkit-secctl.c: Implement SECMPCINTSTATUS Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 22/28] hw/arm/iotkit: Instantiate MPC Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 23/28] hw/arm/iotkit: Wire up MPC interrupt lines Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 24/28] hw/arm/mps2-tz.c: Instantiate MPCs Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 25/28] target/arm: Introduce ARM_FEATURE_M_MAIN Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 26/28] target/arm: Strict alignment for ARMv6-M and ARMv8-M Baseline Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 27/28] vl.c: Don't zero-initialize statics for serial_hds Peter Maydell
2018-06-22 12:57 ` [Qemu-devel] [PULL 28/28] xen: Don't use memory_region_init_ram_nomigrate() in pci_assign_dev_load_option_rom() Peter Maydell
2018-06-22 16:08 ` [Qemu-devel] [PULL 00/28] target-arm queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180622125713.15303-4-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).