From: "Emilio G. Cota" <cota@braap.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage introduced by tb_lock removal
Date: Fri, 22 Jun 2018 13:03:49 -0400 [thread overview]
Message-ID: <20180622170349.GA13208@flamenco> (raw)
In-Reply-To: <CAFEAcA8t7xJQCANL9OLbujuVp0MFX+Z0-_xsQ8iH4YQh2+SNpA@mail.gmail.com>
On Fri, Jun 22, 2018 at 17:24:33 +0100, Peter Maydell wrote:
> On 22 June 2018 at 17:16, Emilio G. Cota <cota@braap.org> wrote:
> It's probably the --enable-debug that makes the difference:
> for instance cpu_reloading_memory_map() is referenced from
> tcg_commit(), which is only called from within an "if (tcg_enabled())"
> guard; with debug disabled the compiler probably figures out that
> tcg_commit() is unreachable and doesn't put it in the .o file.
Yes, I get the same errors with both --enable-debug and --disable-tcg.
> Possibly this has always been broken and wasn't a regression?
> If so I guess we should apply your patch and then fix this
> separately...
v2.12.0 doesn't build either with the options above, so the
regression is fixed with the patch.
I'll send a v2 patch as a separate thread with an updated commit
message to reflect the above.
Thanks,
Emilio
next prev parent reply other threads:[~2018-06-22 17:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 14:37 [Qemu-devel] [PULL v2.5 00/19] tcg queued patches Richard Henderson
2018-06-22 8:58 ` Peter Maydell
2018-06-22 12:46 ` Peter Maydell
2018-06-22 14:40 ` Peter Maydell
2018-06-22 16:16 ` [Qemu-devel] [PATCH] tcg: fix --disable-tcg build breakage introduced by tb_lock removal Emilio G. Cota
2018-06-22 16:24 ` Peter Maydell
2018-06-22 16:42 ` Peter Maydell
2018-06-22 17:03 ` Emilio G. Cota [this message]
2018-06-22 16:23 ` [Qemu-devel] [PULL v2.5 00/19] tcg queued patches Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622170349.GA13208@flamenco \
--to=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).