qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	qemu-arm@nongnu.org
Subject: [Qemu-devel] [PATCH v3 02/16] hw/input/tsc2005: Use qemu_log_mask(GUEST_ERROR) instead of fprintf
Date: Sun, 24 Jun 2018 01:05:55 -0300	[thread overview]
Message-ID: <20180624040609.17572-3-f4bug@amsat.org> (raw)
In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
 hw/input/tsc2005.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c
index 7990954b6c..4dd95596ab 100644
--- a/hw/input/tsc2005.c
+++ b/hw/input/tsc2005.c
@@ -19,6 +19,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "hw/hw.h"
 #include "qemu/timer.h"
 #include "ui/console.h"
@@ -208,9 +209,10 @@ static void tsc2005_write(TSC2005State *s, int reg, uint16_t data)
         }
         s->nextprecision = (data >> 13) & 1;
         s->timing[0] = data & 0x1fff;
-        if ((s->timing[0] >> 11) == 3)
-            fprintf(stderr, "%s: illegal conversion clock setting\n",
-                            __func__);
+        if ((s->timing[0] >> 11) == 3) {
+            qemu_log_mask(LOG_GUEST_ERROR,
+                          "tsc2005_write: illegal conversion clock setting\n");
+        }
         break;
     case 0xd:	/* CFR1 */
         s->timing[1] = data & 0xf07;
@@ -221,8 +223,9 @@ static void tsc2005_write(TSC2005State *s, int reg, uint16_t data)
         break;
 
     default:
-        fprintf(stderr, "%s: write into read-only register %x\n",
-                        __func__, reg);
+        qemu_log_mask(LOG_GUEST_ERROR,
+                      "%s: write into read-only register 0x%x\n",
+                      __func__, reg);
     }
 }
 
-- 
2.18.0

  parent reply	other threads:[~2018-06-24  4:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-24  4:05 [Qemu-devel] [PATCH v3 00/16] hw/arm: use qemu_log_mask instead of fprintf Philippe Mathieu-Daudé
2018-06-24  4:05 ` [Qemu-devel] [PATCH v3 01/16] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) " Philippe Mathieu-Daudé
2018-06-25 11:55   ` Thomas Huth
2018-06-24  4:05 ` Philippe Mathieu-Daudé [this message]
2018-06-24  4:05 ` [Qemu-devel] [PATCH v3 03/16] hw/dma/omap_dma: Use qemu_log_mask(UNIMP) instead of printf Philippe Mathieu-Daudé
2018-06-24  4:05 ` [Qemu-devel] [PATCH v3 04/16] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf Philippe Mathieu-Daudé
2018-06-24  4:05 ` [Qemu-devel] [PATCH v3 05/16] hw/ssi/omap_spi: " Philippe Mathieu-Daudé
2018-06-24  4:05 ` [Qemu-devel] [PATCH v3 06/16] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 07/16] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 08/16] hw/arm/omap1: Use qemu_log_mask(GUEST_ERROR) " Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 09/16] hw/arm/omap: " Philippe Mathieu-Daudé
2018-06-25 12:05   ` Thomas Huth
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 10/16] hw/arm/stellaris: Use qemu_log_mask(UNIMP) " Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 11/16] hw/net/stellaris_enet: Fix a typo Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 12/16] hw/net/stellaris_enet: Use qemu_log_mask(GUEST_ERROR) instead of hw_error Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 13/16] hw/net/smc91c111: " Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 14/16] hw/net/smc91c111: Use qemu_log_mask(UNIMP) instead of fprintf Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 15/16] hw/arm/stellaris: Fix gptm_write() error message Philippe Mathieu-Daudé
2018-06-24  4:06 ` [Qemu-devel] [PATCH v3 16/16] hw/arm/stellaris: Use HWADDR_PRIx to display register address Philippe Mathieu-Daudé
2018-06-26 15:51 ` [Qemu-devel] [PATCH v3 00/16] hw/arm: use qemu_log_mask instead of fprintf Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180624040609.17572-3-f4bug@amsat.org \
    --to=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).