From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXOBi-0002qO-LK for qemu-devel@nongnu.org; Mon, 25 Jun 2018 05:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXOBh-0001LL-BW for qemu-devel@nongnu.org; Mon, 25 Jun 2018 05:53:34 -0400 Date: Mon, 25 Jun 2018 10:53:22 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180625095322.GC18580@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180615142108.27814-1-kwolf@redhat.com> <20180615142108.27814-26-kwolf@redhat.com> <7a310b92-f8cb-b68b-d882-9b2959794347@de.ibm.com> <20180622125502.GF4366@localhost.localdomain> <20180622142513.GH4366@localhost.localdomain> <20180622143146.GQ23296@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180622143146.GQ23296@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Peter Maydell , Boris Fiuczynski , qemu-block@nongnu.org, libvir-list@redhat.com, qemu-devel@nongnu.org, Christian Borntraeger , pkrempa@redhat.com On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrang=C3=A9 wrote: > On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > > Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > > >=20 > > >=20 > > > On 06/22/2018 02:55 PM, Kevin Wolf wrote: > > > > Am 22.06.2018 um 13:38 hat Christian Borntraeger geschrieben: > > > >> > > > >> On 06/15/2018 04:21 PM, Kevin Wolf wrote: > > > >>> The -drive option serial was deprecated in QEMU 2.10. It's time= to > > > >>> remove it. > > > >>> > > > >>> Tests need to be updated to set the serial number with -global = instead > > > >>> of using the -drive option. > > > >> > > > >> libvirt 4.5 still creates those (at least on s390x) > > > >> > > > >> > > > >> > > > >> > > > >> > > > >> skel > > > >> > > > >>
> > > >> > > > >> > > > >> > > > >> ->=20 > > > >> [...] > > > >> -drive file=3D/var/lib/libvirt/qemu/image.zhyp137,format=3Dqcow2= ,if=3Dnone,id=3Ddrive-virtio-disk0,serial=3Dskel,cache=3Dnone,aio=3Dnativ= e -device virtio-blk-ccw,iothread=3Diothread1,scsi=3Doff,devno=3Dfe.0.000= 0,drive=3Ddrive-virtio-disk0,id=3Dvirtio-disk0,bootindex=3D1,write-cache=3D= on=20 > > > >> [...] > > > >> > > > >> 2018-06-22T11:25:20.946024Z qemu-system-s390x: -drive file=3D/va= r/lib/libvirt/qemu/image.zhyp137,format=3Dqcow2,if=3Dnone,id=3Ddrive-virt= io-disk0,serial=3Dskel,cache=3Dnone,aio=3Dnative: Block format 'qcow2' do= es not support the option 'serial' > > > >> 2018-06-22 11:25:21.098+0000: shutting down, reason=3Dfailed > > > >> > > > >> So it seems that this breaks s390x. > > >=20 > > > To me it seems that this is also broken on x86. > > > >=20 > > > > Thanks for bringing this up. libvirt should fix this before QEMU = 3.0 is > > > > released. > > >=20 > > > I think this is definitely too short notice. We should not break ex= isting > > > setups just by insisting that users have to update libvirt when the= y update > > > QEMU. Yes, this might be our policy, but doing so "just because we = can" > > > is certainly a very bad attitude. I see no fundamental technical re= ason why > > > we should not revert this change. > >=20 > > This was in fact one release longer than our deprecation policy says. > > Are we serious about the deprecation policy or aren't we? > >=20 > > I might consider reverting a change if it turned out that this requir= es > > some massive work in libvirt. But I think this one should be rather e= asy > > to fix in libvirt until 3.0 is released. >=20 > It is probably even possible for us to fix it in our July 1st > release Fix posted here: https://www.redhat.com/archives/libvir-list/2018-June/msg01598.html Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|