qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
	f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
	aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup
Date: Mon, 25 Jun 2018 12:19:35 +0100	[thread overview]
Message-ID: <20180625111935.26108-11-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180625111935.26108-1-alex.bennee@linaro.org>

As we don't always take the normal exit path when running a guest we
can skip the normal exit destructors where gcov normally dumps it's
info. The GCC manual suggests long running programs use __gcov_dump()
to flush out the coverage state periodically so we use that here.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 linux-user/exit.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/linux-user/exit.c b/linux-user/exit.c
index aed8713fae..14e94e28fa 100644
--- a/linux-user/exit.c
+++ b/linux-user/exit.c
@@ -19,10 +19,17 @@
 #include "qemu/osdep.h"
 #include "qemu.h"
 
+#ifdef CONFIG_GCOV
+extern void __gcov_dump(void);
+#endif
+
 void preexit_cleanup(CPUArchState *env, int code)
 {
 #ifdef TARGET_GPROF
         _mcleanup();
+#endif
+#ifdef CONFIG_GCOV
+        __gcov_dump();
 #endif
         gdb_exit(env, code);
 }
-- 
2.17.1

  parent reply	other threads:[~2018-06-25 11:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 11:19 [Qemu-devel] [PATCH v1 00/10] Travis updates and code coverage tweaks Alex Bennée
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 01/10] travis: do not waste time cloning unused submodules Alex Bennée
2018-06-29 11:41   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 02/10] travis: test out-of-tree builds Alex Bennée
2018-06-29 11:42   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 03/10] build-system: remove per-test GCOV reporting Alex Bennée
2018-06-29 11:43   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 04/10] .gitignore: add .gcov files Alex Bennée
2018-06-29 11:43   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 05/10] docker: add gcovr to travis image Alex Bennée
2018-06-25 11:32   ` Philippe Mathieu-Daudé
2018-06-29 11:44   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 06/10] travis: add gcovr summary for GCOV build Alex Bennée
2018-06-29 11:45   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 07/10] build-system: add clean-coverage target Alex Bennée
2018-06-29 11:46   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 08/10] build-system: add coverage-report target Alex Bennée
2018-06-29 11:48   ` Daniel P. Berrangé
2018-06-25 11:19 ` [Qemu-devel] [PATCH v1 09/10] linux-user: introduce preexit_cleanup Alex Bennée
2018-06-25 11:34   ` Philippe Mathieu-Daudé
2018-06-29 11:48   ` Daniel P. Berrangé
2018-06-29 14:22   ` Laurent Vivier
2018-06-25 11:19 ` Alex Bennée [this message]
2018-06-25 11:38   ` [Qemu-devel] [PATCH v1 10/10] linux-user: add gcov support to preexit_cleanup Philippe Mathieu-Daudé
2018-06-25 12:47     ` Alex Bennée
2018-07-02  2:04 ` [Qemu-devel] [PATCH v1 00/10] Travis updates and code coverage tweaks no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180625111935.26108-11-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).