From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Nia Alarie <nia.alarie@gmail.com>
Subject: [Qemu-devel] [PULL 6/6] audio: Convert use of atoi to qemu_strtoi
Date: Mon, 25 Jun 2018 15:12:53 +0200 [thread overview]
Message-ID: <20180625131253.11218-7-kraxel@redhat.com> (raw)
In-Reply-To: <20180625131253.11218-1-kraxel@redhat.com>
From: Nia Alarie <nia.alarie@gmail.com>
If qemu_strtoi indicates an error, return the default value.
Signed-off-by: Nia Alarie <nia.alarie@gmail.com>
Message-Id: <20180316144047.30904-1-nia.alarie@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/audio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 6eccdb17ee..d6e91901aa 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -335,9 +335,8 @@ static int audio_get_conf_int (const char *key, int defval, int *defaultp)
char *strval;
strval = getenv (key);
- if (strval) {
+ if (strval && !qemu_strtoi(strval, NULL, 10, &val)) {
*defaultp = 0;
- val = atoi (strval);
return val;
}
else {
--
2.9.3
next prev parent reply other threads:[~2018-06-25 13:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 13:12 [Qemu-devel] [PULL 0/6] Audio 20180625 patches Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO Gerd Hoffmann
2018-06-26 19:55 ` Max Reitz
2018-06-27 6:51 ` Gerd Hoffmann
2018-06-27 7:24 ` Thomas Huth
2018-06-27 7:57 ` [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO) Markus Armbruster
2018-06-27 8:09 ` [Qemu-devel] Drop support for 32bit hosts in qemu? Thomas Huth
2018-06-27 8:56 ` Gerd Hoffmann
2018-06-27 11:08 ` Alex Bennée
2018-06-27 11:09 ` Thomas Huth
2018-06-27 8:15 ` [Qemu-devel] Drop support for 32bit hosts in qemu? (was: [PULL 1/6] audio/hda: create millisecond timers that handle IO) BALATON Zoltan
2018-06-27 8:52 ` Gerd Hoffmann
2018-06-27 9:09 ` Thomas Huth
2018-06-27 13:33 ` Philippe Mathieu-Daudé
2018-06-27 15:41 ` Laurent Vivier
2018-06-27 18:44 ` Dr. David Alan Gilbert
2018-06-27 19:55 ` Laurent Vivier
2018-06-27 10:49 ` Peter Maydell
2018-06-27 11:09 ` Dr. David Alan Gilbert
2018-06-27 13:08 ` Alex Bennée
2018-06-27 13:09 ` Alex Bennée
2018-06-27 11:09 ` Daniel P. Berrangé
2018-06-27 13:03 ` Alex Bennée
2018-06-27 13:38 ` Philippe Mathieu-Daudé
2018-06-27 13:02 ` [Qemu-devel] Drop support for 32bit hosts in qemu? Juan Quintela
2018-06-27 13:11 ` Daniel P. Berrangé
2018-06-27 11:13 ` [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO Gerd Hoffmann
2018-06-27 13:15 ` Paolo Bonzini
2018-06-27 12:21 ` Eric Blake
2018-06-29 8:19 ` Peter Maydell
2018-06-29 15:11 ` Eric Blake
2018-06-25 13:12 ` [Qemu-devel] [PULL 2/6] audio/hda: turn some dprintfs into trace points Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 3/6] audio/hda: tweak timer adjust logic Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 4/6] audio/hda: detect output buffer overruns Gerd Hoffmann
2018-06-25 13:12 ` [Qemu-devel] [PULL 5/6] audio/hda: enable new timer code by default Gerd Hoffmann
2018-06-25 13:12 ` Gerd Hoffmann [this message]
2018-06-25 15:37 ` [Qemu-devel] [PULL 0/6] Audio 20180625 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625131253.11218-7-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=nia.alarie@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).