qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [Qemu-devel] [PULL 02/12] i386: improve alignment of CPU model listing
Date: Mon, 25 Jun 2018 19:25:14 -0300	[thread overview]
Message-ID: <20180625222524.382-3-ehabkost@redhat.com> (raw)
In-Reply-To: <20180625222524.382-1-ehabkost@redhat.com>

From: Daniel P. Berrangé <berrange@redhat.com>

Since the addition of the -IBRS CPU model variants, the descriptions
shown by '-cpu help' are not well aligned, as several model names
overflow the space allowed. Right aligning the CPU model names is also
not attractive, because it obscures the common name prefixes of many
models. The CPU model name field needs to be 4 characters larger, and
be left aligned instead.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20180606165527.17365-2-berrange@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target/i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 86fb1a4fb8..e1d7157d8c 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -3380,7 +3380,7 @@ static void x86_cpu_list_entry(gpointer data, gpointer user_data)
         desc = cc->cpu_def->model_id;
     }
 
-    (*s->cpu_fprintf)(s->file, "x86 %16s  %-48s\n",
+    (*s->cpu_fprintf)(s->file, "x86 %-20s  %-48s\n",
                       name, desc);
     g_free(name);
 }
-- 
2.18.0.rc1.1.g3f1ff2140

  parent reply	other threads:[~2018-06-25 22:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 22:25 [Qemu-devel] [PULL 00/12] x86 queue, 2018-06-25 Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 01/12] i386: Add support for CPUID_8000_001E for AMD Eduardo Habkost
2018-06-25 22:25 ` Eduardo Habkost [this message]
2018-06-25 22:25 ` [Qemu-devel] [PULL 03/12] i386: improve sorting of CPU model names Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 04/12] i386: display known CPUID features linewrapped, in alphabetical order Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 05/12] i386: Remove osxsave CPUID flag name Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 06/12] i386: Remove ospke " Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 07/12] i386: define the AMD 'amd-ssbd' CPUID feature bit Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 08/12] i386: Define AMD's no SSB mitigation needed Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 09/12] i386: Allow TOPOEXT to be enabled on older kernels Eduardo Habkost
2018-08-09 20:29   ` Richard W.M. Jones
2018-06-25 22:25 ` [Qemu-devel] [PULL 10/12] i386: Fix up the Node id for CPUID_8000_001E Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 11/12] i386: Enable TOPOEXT feature on AMD EPYC CPU Eduardo Habkost
2018-06-25 22:25 ` [Qemu-devel] [PULL 12/12] i386: Remove generic SMT thread check Eduardo Habkost
2018-06-26 11:49 ` [Qemu-devel] [PULL 00/12] x86 queue, 2018-06-25 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180625222524.382-3-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).