qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, stefanha@redhat.com,
	qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/6] file-posix: Make truncate/preallocate asynchronous
Date: Tue, 26 Jun 2018 16:24:28 +0200	[thread overview]
Message-ID: <20180626142434.22090-1-kwolf@redhat.com> (raw)

This fixes the problem that blockdev-create on a local file blocks the
main loop despite being a background job. This was caused by file-posix
preallocating the image with blocking syscalls rather than moving this
to the thread pool and yielding the coroutine meanwhile.

v2:
- Add locking to qcow2_co_discard()
- Extra qcow2 fix and cleanup related to the locking code
- Use tracked requests infrastructure for serialising I/O requests
  against truncate in newly allocated areas

Kevin Wolf (6):
  qcow2: Fix qcow2_truncate() error return value
  block: Convert .bdrv_truncate callback to coroutine_fn
  qcow2: Remove coroutine trampoline for preallocate_co()
  block: Move bdrv_truncate() implementation to io.c
  block: Use tracked request for truncate
  file-posix: Make .bdrv_co_truncate asynchronous

 include/block/block.h     |   4 +
 include/block/block_int.h |   7 +-
 include/block/raw-aio.h   |   4 +-
 block.c                   |  64 +----------
 block/copy-on-read.c      |   8 +-
 block/crypto.c            |   9 +-
 block/file-posix.c        | 277 ++++++++++++++++++++++++++--------------------
 block/file-win32.c        |   6 +-
 block/gluster.c           |  14 ++-
 block/io.c                | 134 ++++++++++++++++++++++
 block/iscsi.c             |   8 +-
 block/nfs.c               |   7 +-
 block/qcow2.c             | 124 +++++++++------------
 block/qed.c               |   8 +-
 block/raw-format.c        |   8 +-
 block/rbd.c               |   8 +-
 block/sheepdog.c          |  12 +-
 block/ssh.c               |   6 +-
 18 files changed, 405 insertions(+), 303 deletions(-)

-- 
2.13.6

             reply	other threads:[~2018-06-26 14:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26 14:24 Kevin Wolf [this message]
2018-06-26 14:24 ` [Qemu-devel] [PATCH v2 1/6] qcow2: Fix qcow2_truncate() error return value Kevin Wolf
2018-06-27 11:51   ` Stefan Hajnoczi
2018-06-26 14:24 ` [Qemu-devel] [PATCH v2 2/6] block: Convert .bdrv_truncate callback to coroutine_fn Kevin Wolf
2018-06-27 11:54   ` Stefan Hajnoczi
2018-06-26 14:24 ` [Qemu-devel] [PATCH v2 3/6] qcow2: Remove coroutine trampoline for preallocate_co() Kevin Wolf
2018-06-27 11:55   ` Stefan Hajnoczi
2018-06-26 14:24 ` [Qemu-devel] [PATCH v2 4/6] block: Move bdrv_truncate() implementation to io.c Kevin Wolf
2018-06-27 11:56   ` Stefan Hajnoczi
2018-06-26 14:24 ` [Qemu-devel] [PATCH v2 5/6] block: Use tracked request for truncate Kevin Wolf
2018-06-27 11:57   ` Stefan Hajnoczi
2018-06-26 14:24 ` [Qemu-devel] [PATCH v2 6/6] file-posix: Make .bdrv_co_truncate asynchronous Kevin Wolf
2018-06-27 11:57   ` Stefan Hajnoczi
2018-06-27 11:58 ` [Qemu-devel] [PATCH v2 0/6] file-posix: Make truncate/preallocate asynchronous Stefan Hajnoczi
2018-06-27 12:42   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180626142434.22090-1-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).