From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXpFO-0004Ph-Q1 for qemu-devel@nongnu.org; Tue, 26 Jun 2018 10:47:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXpFO-0004MO-3K for qemu-devel@nongnu.org; Tue, 26 Jun 2018 10:47:10 -0400 Date: Tue, 26 Jun 2018 16:46:59 +0200 From: Kevin Wolf Message-ID: <20180626144659.GC3964@dhcp-200-186.str.redhat.com> References: <20180614142944.10084-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180614142944.10084-1-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_{open, create}_opts_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, mreitz@redhat.com, qemu-block@nongnu.org, berrange@redhat.com Am 14.06.2018 um 16:29 hat Markus Armbruster geschrieben: > block_crypto_open_opts_init() and block_crypto_create_opts_init() > contain a virtual visit of QCryptoBlockOptions and > QCryptoBlockCreateOptions less member "format", respectively. > > Change their callers to put member "format" in the QDict, so they can > use the generated visitors for these types instead. > > Signed-off-by: Markus Armbruster This doesn't seem to apply cleanly any more. Can you rebase? Kevin