From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v16 11/14] migration: Start sending messages
Date: Tue, 26 Jun 2018 20:19:29 +0200 [thread overview]
Message-ID: <20180626181932.11909-11-quintela@redhat.com> (raw)
In-Reply-To: <20180626181932.11909-1-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/ram.c | 29 ++++++++++++++++++++++++-----
1 file changed, 24 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 050e2f2000..b9c8f65059 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -736,9 +736,6 @@ static int multifd_recv_unfill_packet(MultiFDRecvParams *p, Error **errp)
RAMBlock *block;
int i;
- /* ToDo: We can't use it until we haven't received a message */
- return 0;
-
be32_to_cpus(&packet->magic);
if (packet->magic != MULTIFD_MAGIC) {
error_setg(errp, "multifd: received packet "
@@ -994,6 +991,7 @@ static void *multifd_send_thread(void *opaque)
{
MultiFDSendParams *p = opaque;
Error *local_err = NULL;
+ int ret;
trace_multifd_send_thread_start(p->id);
@@ -1021,7 +1019,16 @@ static void *multifd_send_thread(void *opaque)
trace_multifd_send(p->id, packet_num, used, flags);
- /* ToDo: send packet here */
+ ret = qio_channel_write_all(p->c, (void *)p->packet,
+ p->packet_len, &local_err);
+ if (ret != 0) {
+ break;
+ }
+
+ ret = qio_channel_writev_all(p->c, p->pages->iov, used, &local_err);
+ if (ret != 0) {
+ break;
+ }
qemu_mutex_lock(&p->mutex);
p->pending_job--;
@@ -1230,7 +1237,14 @@ static void *multifd_recv_thread(void *opaque)
uint32_t used;
uint32_t flags;
- /* ToDo: recv packet here */
+ ret = qio_channel_read_all_eof(p->c, (void *)p->packet,
+ p->packet_len, &local_err);
+ if (ret == 0) { /* EOF */
+ break;
+ }
+ if (ret == -1) { /* Error */
+ break;
+ }
qemu_mutex_lock(&p->mutex);
ret = multifd_recv_unfill_packet(p, &local_err);
@@ -1247,6 +1261,11 @@ static void *multifd_recv_thread(void *opaque)
p->num_pages += used;
qemu_mutex_unlock(&p->mutex);
+ ret = qio_channel_readv_all(p->c, p->pages->iov, used, &local_err);
+ if (ret != 0) {
+ break;
+ }
+
if (flags & MULTIFD_FLAG_SYNC) {
qemu_sem_post(&multifd_recv_state->sem_sync);
qemu_sem_wait(&p->sem_sync);
--
2.17.1
next prev parent reply other threads:[~2018-06-26 18:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 18:19 [Qemu-devel] [PATCH v16 01/14] migration: Create multipage support Juan Quintela
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 02/14] migration: Create multifd packet Juan Quintela
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 03/14] migration: Calculate mbps only during transfer time Juan Quintela
2018-06-27 9:28 ` Dr. David Alan Gilbert
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 04/14] migration: Abstract the number of bytes sent Juan Quintela
2018-06-27 9:46 ` Dr. David Alan Gilbert
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 05/14] migration: Add multifd traces for start/end thread Juan Quintela
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 06/14] migration: Multifd channels always wait on the sem Juan Quintela
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 07/14] migration: Add block where to send/receive packets Juan Quintela
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 08/14] migration: Synchronize multifd threads with main thread Juan Quintela
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 09/14] migration: Create multifd_bytes ram_counter Juan Quintela
2018-06-27 10:01 ` Dr. David Alan Gilbert
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 10/14] migration: Create ram_save_multifd_page Juan Quintela
2018-06-26 18:19 ` Juan Quintela [this message]
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 12/14] migration: Wait for blocking IO Juan Quintela
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 13/14] migration: Remove not needed semaphore and quit Juan Quintela
2018-06-27 10:46 ` Dr. David Alan Gilbert
2018-06-26 18:19 ` [Qemu-devel] [PATCH v16 14/14] migration: Stop sending whole pages through main channel Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180626181932.11909-11-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).