* [Qemu-devel] [PATCH] ppc/pnv: fix pnv_core_realize() error handling
@ 2018-06-26 14:22 Cédric Le Goater
2018-06-26 16:17 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Cédric Le Goater @ 2018-06-26 14:22 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-ppc, qemu-devel, Cédric Le Goater
commit d35aefa9ae15 ("ppc/pnv: introduce a new intc_create() operation
to the chip model") changed the object link in the pnv_core_realize()
routine but a return was forgotten in case of error, which can lead to
more problems afterwards (segv)
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/ppc/pnv_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
index a9f129fc2c5f..9750464bf4a1 100644
--- a/hw/ppc/pnv_core.c
+++ b/hw/ppc/pnv_core.c
@@ -150,6 +150,7 @@ static void pnv_core_realize(DeviceState *dev, Error **errp)
if (!chip) {
error_propagate(errp, local_err);
error_prepend(errp, "required link 'chip' not found: ");
+ return;
}
pc->threads = g_new(PowerPCCPU *, cc->nr_threads);
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/pnv: fix pnv_core_realize() error handling
2018-06-26 14:22 [Qemu-devel] [PATCH] ppc/pnv: fix pnv_core_realize() error handling Cédric Le Goater
@ 2018-06-26 16:17 ` Greg Kurz
2018-06-26 16:46 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-27 0:35 ` David Gibson
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kurz @ 2018-06-26 16:17 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: David Gibson, qemu-ppc, qemu-devel
On Tue, 26 Jun 2018 16:22:14 +0200
Cédric Le Goater <clg@kaod.org> wrote:
> commit d35aefa9ae15 ("ppc/pnv: introduce a new intc_create() operation
> to the chip model") changed the object link in the pnv_core_realize()
> routine but a return was forgotten in case of error, which can lead to
> more problems afterwards (segv)
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> hw/ppc/pnv_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index a9f129fc2c5f..9750464bf4a1 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -150,6 +150,7 @@ static void pnv_core_realize(DeviceState *dev, Error **errp)
> if (!chip) {
> error_propagate(errp, local_err);
> error_prepend(errp, "required link 'chip' not found: ");
> + return;
> }
>
> pc->threads = g_new(PowerPCCPU *, cc->nr_threads);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ppc/pnv: fix pnv_core_realize() error handling
2018-06-26 14:22 [Qemu-devel] [PATCH] ppc/pnv: fix pnv_core_realize() error handling Cédric Le Goater
2018-06-26 16:17 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
@ 2018-06-26 16:46 ` Philippe Mathieu-Daudé
2018-06-27 0:35 ` David Gibson
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-06-26 16:46 UTC (permalink / raw)
To: Cédric Le Goater, David Gibson; +Cc: qemu-ppc, qemu-devel
On 06/26/2018 11:22 AM, Cédric Le Goater wrote:
> commit d35aefa9ae15 ("ppc/pnv: introduce a new intc_create() operation
> to the chip model") changed the object link in the pnv_core_realize()
> routine but a return was forgotten in case of error, which can lead to
> more problems afterwards (segv)
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/ppc/pnv_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index a9f129fc2c5f..9750464bf4a1 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -150,6 +150,7 @@ static void pnv_core_realize(DeviceState *dev, Error **errp)
> if (!chip) {
> error_propagate(errp, local_err);
> error_prepend(errp, "required link 'chip' not found: ");
> + return;
> }
>
> pc->threads = g_new(PowerPCCPU *, cc->nr_threads);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ppc/pnv: fix pnv_core_realize() error handling
2018-06-26 14:22 [Qemu-devel] [PATCH] ppc/pnv: fix pnv_core_realize() error handling Cédric Le Goater
2018-06-26 16:17 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-06-26 16:46 ` [Qemu-devel] " Philippe Mathieu-Daudé
@ 2018-06-27 0:35 ` David Gibson
2 siblings, 0 replies; 4+ messages in thread
From: David Gibson @ 2018-06-27 0:35 UTC (permalink / raw)
To: Cédric Le Goater; +Cc: qemu-ppc, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
On Tue, Jun 26, 2018 at 04:22:14PM +0200, Cédric Le Goater wrote:
> commit d35aefa9ae15 ("ppc/pnv: introduce a new intc_create() operation
> to the chip model") changed the object link in the pnv_core_realize()
> routine but a return was forgotten in case of error, which can lead to
> more problems afterwards (segv)
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-for-3.0, thanks.
> ---
> hw/ppc/pnv_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index a9f129fc2c5f..9750464bf4a1 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c
> @@ -150,6 +150,7 @@ static void pnv_core_realize(DeviceState *dev, Error **errp)
> if (!chip) {
> error_propagate(errp, local_err);
> error_prepend(errp, "required link 'chip' not found: ");
> + return;
> }
>
> pc->threads = g_new(PowerPCCPU *, cc->nr_threads);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-27 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-26 14:22 [Qemu-devel] [PATCH] ppc/pnv: fix pnv_core_realize() error handling Cédric Le Goater
2018-06-26 16:17 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2018-06-26 16:46 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-27 0:35 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).