qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PULL 14/16] migration: Stop sending whole pages through main channel
Date: Wed, 27 Jun 2018 14:56:02 +0200	[thread overview]
Message-ID: <20180627125604.15275-15-quintela@redhat.com> (raw)
In-Reply-To: <20180627125604.15275-1-quintela@redhat.com>

We have to flush() the QEMUFile because now we sent really few data
through that channel.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/ram.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/migration/ram.c b/migration/ram.c
index 61f7313093..7d23b472cb 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1817,15 +1817,7 @@ static int ram_save_page(RAMState *rs, PageSearchStatus *pss, bool last_stage)
 static int ram_save_multifd_page(RAMState *rs, RAMBlock *block,
                                  ram_addr_t offset)
 {
-    uint8_t *p;
-
-    p = block->host + offset;
-
-    ram_counters.transferred += save_page_header(rs, rs->f, block,
-                                                 offset | RAM_SAVE_FLAG_PAGE);
     multifd_queue_page(block, offset);
-    qemu_put_buffer(rs->f, p, TARGET_PAGE_SIZE);
-    ram_counters.transferred += TARGET_PAGE_SIZE;
     ram_counters.normal++;
 
     return 1;
@@ -3066,6 +3058,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
 
     multifd_send_sync_main();
     qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
+    qemu_fflush(f);
 
     return 0;
 }
@@ -3148,6 +3141,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)
     multifd_send_sync_main();
 out:
     qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
+    qemu_fflush(f);
     ram_counters.transferred += 8;
 
     ret = qemu_file_get_error(f);
@@ -3201,6 +3195,7 @@ static int ram_save_complete(QEMUFile *f, void *opaque)
 
     multifd_send_sync_main();
     qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
+    qemu_fflush(f);
 
     return 0;
 }
-- 
2.17.1

  parent reply	other threads:[~2018-06-27 12:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 12:55 [Qemu-devel] [PULL 00/16] Migration Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 01/16] migration: Create multipage support Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 02/16] migration: Create multifd packet Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 03/16] migration: Calculate mbps only during transfer time Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 04/16] migration: Abstract the number of bytes sent Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 05/16] migration: Add multifd traces for start/end thread Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 06/16] migration: Multifd channels always wait on the sem Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 07/16] migration: Add block where to send/receive packets Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 08/16] migration: Synchronize multifd threads with main thread Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 09/16] migration: Create multifd_bytes ram_counter Juan Quintela
2018-06-27 12:55 ` [Qemu-devel] [PULL 10/16] migration: Create ram_save_multifd_page Juan Quintela
2018-07-06 10:57   ` Peter Maydell
2018-06-27 12:55 ` [Qemu-devel] [PULL 11/16] migration: Start sending messages Juan Quintela
2018-06-27 12:56 ` [Qemu-devel] [PULL 12/16] migration: Wait for blocking IO Juan Quintela
2018-06-27 12:56 ` [Qemu-devel] [PULL 13/16] migration: Remove not needed semaphore and quit Juan Quintela
2018-06-27 12:56 ` Juan Quintela [this message]
2018-06-27 12:56 ` [Qemu-devel] [PULL 15/16] postcopy: drop ram_pages parameter from postcopy_ram_incoming_init() Juan Quintela
2018-06-27 12:56 ` [Qemu-devel] [PULL 16/16] migration: fix crash in when incoming client channel setup fails Juan Quintela
2018-06-28  9:55   ` Balamuruhan S
2018-06-28 11:06     ` Juan Quintela
2018-06-29  9:11       ` Balamuruhan S
2018-06-28 15:28 ` [Qemu-devel] [PULL 00/16] Migration Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627125604.15275-15-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).