From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fY8gW-00017z-7X for qemu-devel@nongnu.org; Wed, 27 Jun 2018 07:32:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fY8gV-0005KW-9s for qemu-devel@nongnu.org; Wed, 27 Jun 2018 07:32:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:48628 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fY8gV-0005K9-5F for qemu-devel@nongnu.org; Wed, 27 Jun 2018 07:32:27 -0400 Date: Wed, 27 Jun 2018 13:32:21 +0200 From: Igor Mammedov Message-ID: <20180627133221.0d90cc9a@redhat.com> In-Reply-To: <20180626122343.13473-2-marcandre.lureau@redhat.com> References: <20180626122343.13473-1-marcandre.lureau@redhat.com> <20180626122343.13473-2-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 1/4] tpm: add a "ppi" boolean property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Cc: qemu-devel@nongnu.org, Paolo Bonzini , stefanb@linux.vnet.ibm.com, Marcel Apfelbaum , Eduardo Habkost , "Michael S. Tsirkin" , Richard Henderson On Tue, 26 Jun 2018 14:23:40 +0200 Marc-Andr=C3=A9 Lureau wrote: > The following patches implement the TPM Physical Presence Interface, > make use of a new memory region and a fw_cfg entry. Enable PPI by > default with >2.12 machine type, to avoid migration issues. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Igor Mammedov > --- > include/hw/compat.h | 10 ++++++++++ > hw/tpm/tpm_crb.c | 3 +++ > hw/tpm/tpm_tis.c | 3 +++ > 3 files changed, 16 insertions(+) >=20 > diff --git a/include/hw/compat.h b/include/hw/compat.h > index 44d5964060..01758991a0 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -2,6 +2,16 @@ > #define HW_COMPAT_H > =20 > #define HW_COMPAT_2_12 \ > + {\ > + .driver =3D "tpm-crb",\ > + .property =3D "ppi",\ > + .value =3D "false",\ > + },\ > + {\ > + .driver =3D "tpm-tis",\ > + .property =3D "ppi",\ > + .value =3D "false",\ > + },\ > {\ > .driver =3D "migration",\ > .property =3D "decompress-error-check",\ > diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c > index a92dd50437..d5b0ac5920 100644 > --- a/hw/tpm/tpm_crb.c > +++ b/hw/tpm/tpm_crb.c > @@ -41,6 +41,8 @@ typedef struct CRBState { > MemoryRegion cmdmem; > =20 > size_t be_buffer_size; > + > + bool ppi_enabled; > } CRBState; > =20 > #define CRB(obj) OBJECT_CHECK(CRBState, (obj), TYPE_TPM_CRB) > @@ -221,6 +223,7 @@ static const VMStateDescription vmstate_tpm_crb =3D { > =20 > static Property tpm_crb_properties[] =3D { > DEFINE_PROP_TPMBE("tpmdev", CRBState, tpmbe), > + DEFINE_PROP_BOOL("ppi", CRBState, ppi_enabled, true), > DEFINE_PROP_END_OF_LIST(), > }; > =20 > diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c > index 12f5c9a759..d9ddf9b723 100644 > --- a/hw/tpm/tpm_tis.c > +++ b/hw/tpm/tpm_tis.c > @@ -81,6 +81,8 @@ typedef struct TPMState { > TPMVersion be_tpm_version; > =20 > size_t be_buffer_size; > + > + bool ppi_enabled; > } TPMState; > =20 > #define TPM(obj) OBJECT_CHECK(TPMState, (obj), TYPE_TPM_TIS) > @@ -950,6 +952,7 @@ static const VMStateDescription vmstate_tpm_tis =3D { > static Property tpm_tis_properties[] =3D { > DEFINE_PROP_UINT32("irq", TPMState, irq_num, TPM_TIS_IRQ), > DEFINE_PROP_TPMBE("tpmdev", TPMState, be_driver), > + DEFINE_PROP_BOOL("ppi", TPMState, ppi_enabled, true), > DEFINE_PROP_END_OF_LIST(), > }; > =20