Re: [Qemu-devel] [PATCH] Partially revert "python: futurize -f libfuturize.fixes.fix_absolute_import"

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]

On Thu, Jun 21, 2018 at 02:54:51PM -0300, Eduardo Habkost wrote:
> Since commit 068cf7a44cd4d65c05aa877dbebced295be5ce44, qmp-shell
> is broken:
> 
>   $ ./scripts/qmp/qmp-shell
>   Traceback (most recent call last):
>     File "./scripts/qmp/qmp-shell", line 70, in <module>
>       from . import qmp
>   ValueError: Attempted relative import in non-package
> 
> Relative imports don't work on scripts that are executed
> directly, so revert the change on the scripts inside scripts/qmp.
> 
> Fixes: 068cf7a44cd4d65c05aa877dbebced295be5ce44
> Reported-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  scripts/qmp/qemu-ga-client | 3 +--
>  scripts/qmp/qmp            | 3 +--
>  scripts/qmp/qmp-shell      | 3 +--
>  scripts/qmp/qom-fuse       | 3 +--
>  scripts/qmp/qom-get        | 3 +--
>  scripts/qmp/qom-list       | 3 +--
>  scripts/qmp/qom-set        | 3 +--
>  scripts/qmp/qom-tree       | 3 +--
>  8 files changed, 8 insertions(+), 16 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]