qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/5] migration: do explicit incoming setup for rdma
Date: Wed, 27 Jun 2018 15:13:04 +0100	[thread overview]
Message-ID: <20180627141303.GH2423@work-vm> (raw)
In-Reply-To: <20180627130319.GF2516@xz-mi>

* Peter Xu (peterx@redhat.com) wrote:
> On Wed, Jun 27, 2018 at 01:25:45PM +0100, Dr. David Alan Gilbert wrote:
> > * Peter Xu (peterx@redhat.com) wrote:
> > > RDMA does not support postcopy recovery, so no need to go into such
> > > logic.  Instead of calling migration_fd_process_incoming(), let's call
> > > the two functions that setup the incoming migration.  There should have
> > > no functional change at all.
> > 
> > Can you explain why we need to though?  The reason I ask is that there
> > is Lidong Chen's work that gets postcopy partially working with RDMA, so
> > then the next question is bound to be recovery.
> 
> Ah if so this patch needs to change.  Could you paste me the message
> id of the work?  Or link?
> 
> After all I'll need to keep this bit, but I am just curious about what
> is "partially" mean here. :)

https://patchwork.ozlabs.org/cover/925525/

It enables postcopy with RDMA, but once it switches into postcopy mode
it doesn't use the fast features of RDMA, it still shuffles the data
as a stream (using some more basic RDMA features).

Dave

> Thanks,
> 
> -- 
> Peter Xu
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2018-06-27 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 10:51 [Qemu-devel] [PATCH v2 0/5] migation: unbreak postcopy recovery Peter Xu
2018-06-27 10:51 ` [Qemu-devel] [PATCH v2 1/5] migration: delay postcopy paused state Peter Xu
2018-06-27 10:51 ` [Qemu-devel] [PATCH v2 2/5] migration: move income process out of multifd Peter Xu
2018-06-27 10:51 ` [Qemu-devel] [PATCH v2 3/5] migration: do explicit incoming setup for rdma Peter Xu
2018-06-27 12:25   ` Dr. David Alan Gilbert
2018-06-27 13:03     ` Peter Xu
2018-06-27 14:13       ` Dr. David Alan Gilbert [this message]
2018-06-29  6:58         ` Peter Xu
2018-06-27 10:51 ` [Qemu-devel] [PATCH v2 4/5] migration: unbreak postcopy recovery Peter Xu
2018-06-27 10:51 ` [Qemu-devel] [PATCH v2 5/5] migration: unify incoming processing Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627141303.GH2423@work-vm \
    --to=dgilbert@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).