From: Stefan Hajnoczi <stefanha@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] simpletrace: Convert name from mapping record to str
Date: Wed, 27 Jun 2018 15:52:27 +0100 [thread overview]
Message-ID: <20180627145227.GC6623@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180619194549.15584-1-ehabkost@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
On Tue, Jun 19, 2018 at 04:45:49PM -0300, Eduardo Habkost wrote:
> The rest of the code assumes that idtoname is a (int -> str)
> dictionary, so convert the data accordingly.
>
> This is necessary to make the script work with Python 3 (where
> reads from a binary file return 'bytes' objects, not 'str').
>
> Fixes the following error:
>
> $ python3 ./scripts/simpletrace.py trace-events-all trace-27445
> b'object_class_dynamic_cast_assert' event is logged but is not \
> declared in the trace events file, try using trace-events-all instead.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> scripts/simpletrace.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I can now successfully run simpletrace.py using Python 3. Thanks!
Thanks, applied to my tracing-next tree:
https://github.com/stefanha/qemu/commits/tracing-next
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2018-06-27 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 19:45 [Qemu-devel] [PATCH] simpletrace: Convert name from mapping record to str Eduardo Habkost
2018-06-19 22:59 ` no-reply
2018-06-27 14:14 ` Stefan Hajnoczi
2018-06-27 14:52 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180627145227.GC6623@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).