From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYC1T-0007ii-F8 for qemu-devel@nongnu.org; Wed, 27 Jun 2018 11:06:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYC1N-0005OZ-Jm for qemu-devel@nongnu.org; Wed, 27 Jun 2018 11:06:19 -0400 Date: Wed, 27 Jun 2018 17:06:09 +0200 From: Cornelia Huck Message-ID: <20180627170609.0a99d353.cohuck@redhat.com> In-Reply-To: <20180627134410.4901-1-david@redhat.com> References: <20180627134410.4901-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/9] s390x: TOD refactoring + TCG CPU hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Richard Henderson , Alexander Graf , Christian Borntraeger , Thomas Huth On Wed, 27 Jun 2018 15:44:01 +0200 David Hildenbrand wrote: > The TOD in TCG is not handled correctly: > - each CPU has its own TOD based on CPU creation time vs. a system TOD > - TOD is not migrated > - TOD timer is not restarted during migration > - CKC interrupts/TOD timer is not cleared when resetting the CKC > > This (and a cpu creation problem for single threaded TCG) currently made > CPU hotplug under TCG not work. Now it's working > > The third patch also refactors TOD handling for KVM (moved into a new > TOD device). The second patch makes sure that we can use a const pointer > for the new TOD clock struct. Thanks, applied.