[Qemu-devel] [PATCH 0/2] linux-user: minor fixes

[Qemu-devel] [PATCH 0/2] linux-user: minor fixes

[Laurent Vivier]

This series fixes a couple of problem I've found
using the libuv test suite.

Laurent Vivier (2):
  linux-user: add netlink CARRIER_UP_COUNT/CARRIER_DOWN_COUNT
  linux-user: update do_setsockopt()

 linux-user/syscall.c | 4 ++++
 1 file changed, 4 insertions(+)

-- 
2.14.4

[Qemu-devel] [PATCH 1/2] linux-user: add netlink CARRIER_UP_COUNT/CARRIER_DOWN_COUNT

[Laurent Vivier]

Error is reported with libuv test suite:

 not ok 311 - udp_multicast_interface6
 # exit code 134
 # Output from process `udp_multicast_interface6`:
 # Unknown host QEMU_IFLA type: 47
 # Unknown host QEMU_IFLA type: 48
 # Unknown host QEMU_IFLA type: 47
 # Unknown host QEMU_IFLA type: 48
 # Unknown host QEMU_IFLA type: 47
 # Unknown host QEMU_IFLA type: 48
 # Unknown host QEMU_IFLA type: 47
 # Unknown host QEMU_IFLA type: 48
 # Unknown host QEMU_IFLA type: 47
 # Unknown host QEMU_IFLA type: 48

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/syscall.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 2117fb13b4..4460f1e39a 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2522,6 +2522,8 @@ static abi_long host_to_target_data_link_rtattr(struct rtattr *rtattr)
     case QEMU_IFLA_NUM_VF:
     case QEMU_IFLA_GSO_MAX_SEGS:
     case QEMU_IFLA_GSO_MAX_SIZE:
+    case QEMU_IFLA_CARRIER_UP_COUNT:
+    case QEMU_IFLA_CARRIER_DOWN_COUNT:
         u32 = RTA_DATA(rtattr);
         *u32 = tswap32(*u32);
         break;
-- 
2.14.4

[Qemu-devel] [PATCH 2/2] linux-user: update do_setsockopt()

[Laurent Vivier]

add IPV6_MULTICAST_HOPS and IPV6_MULTICAST_LOOP that need
32bit value conversion

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/syscall.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 4460f1e39a..50e20fb659 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -3019,6 +3019,8 @@ static abi_long do_setsockopt(int sockfd, int level, int optname,
         case IPV6_V6ONLY:
         case IPV6_RECVPKTINFO:
         case IPV6_UNICAST_HOPS:
+        case IPV6_MULTICAST_HOPS:
+        case IPV6_MULTICAST_LOOP:
         case IPV6_RECVERR:
         case IPV6_RECVHOPLIMIT:
         case IPV6_2292HOPLIMIT:
-- 
2.14.4

Re: [Qemu-devel] [PATCH 1/2] linux-user: add netlink CARRIER_UP_COUNT/CARRIER_DOWN_COUNT

[Philippe Mathieu-Daudé]

On 06/27/2018 06:21 PM, Laurent Vivier wrote:
> Error is reported with libuv test suite:
> 
>  not ok 311 - udp_multicast_interface6
>  # exit code 134
>  # Output from process `udp_multicast_interface6`:
>  # Unknown host QEMU_IFLA type: 47
>  # Unknown host QEMU_IFLA type: 48
>  # Unknown host QEMU_IFLA type: 47
>  # Unknown host QEMU_IFLA type: 48
>  # Unknown host QEMU_IFLA type: 47
>  # Unknown host QEMU_IFLA type: 48
>  # Unknown host QEMU_IFLA type: 47
>  # Unknown host QEMU_IFLA type: 48
>  # Unknown host QEMU_IFLA type: 47
>  # Unknown host QEMU_IFLA type: 48
> 
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  linux-user/syscall.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 2117fb13b4..4460f1e39a 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2522,6 +2522,8 @@ static abi_long host_to_target_data_link_rtattr(struct rtattr *rtattr)
>      case QEMU_IFLA_NUM_VF:
>      case QEMU_IFLA_GSO_MAX_SEGS:
>      case QEMU_IFLA_GSO_MAX_SIZE:
> +    case QEMU_IFLA_CARRIER_UP_COUNT:
> +    case QEMU_IFLA_CARRIER_DOWN_COUNT:
>          u32 = RTA_DATA(rtattr);
>          *u32 = tswap32(*u32);
>          break;
> 

Re: [Qemu-devel] [PATCH 2/2] linux-user: update do_setsockopt()

[Philippe Mathieu-Daudé]

On 06/27/2018 06:21 PM, Laurent Vivier wrote:
> add IPV6_MULTICAST_HOPS and IPV6_MULTICAST_LOOP that need
> 32bit value conversion
> 
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  linux-user/syscall.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 4460f1e39a..50e20fb659 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3019,6 +3019,8 @@ static abi_long do_setsockopt(int sockfd, int level, int optname,
>          case IPV6_V6ONLY:
>          case IPV6_RECVPKTINFO:
>          case IPV6_UNICAST_HOPS:
> +        case IPV6_MULTICAST_HOPS:
> +        case IPV6_MULTICAST_LOOP:
>          case IPV6_RECVERR:
>          case IPV6_RECVHOPLIMIT:
>          case IPV6_2292HOPLIMIT:
>