From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYa8k-0001rN-Kn for qemu-devel@nongnu.org; Thu, 28 Jun 2018 12:51:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYa8j-0005mL-Nu for qemu-devel@nongnu.org; Thu, 28 Jun 2018 12:51:26 -0400 Date: Thu, 28 Jun 2018 17:51:18 +0100 From: "Richard W.M. Jones" Message-ID: <20180628165118.GH1455@redhat.com> References: <20180628132211.8795-1-rjones@redhat.com> <20180628132211.8795-2-rjones@redhat.com> <20180628160620.GS3513@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180628160620.GS3513@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] crypto: Implement TLS Pre-Shared Keys (PSK). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Eric Blake , qemu-devel@nongnu.org, qemu-block@nongnu.org On Thu, Jun 28, 2018 at 05:06:20PM +0100, Daniel P. Berrang=E9 wrote: > On Thu, Jun 28, 2018 at 09:42:18AM -0500, Eric Blake wrote: > > Does it make sense to forbid this operation on servers (since it only= makes > > sense for clients)? >=20 > We can't validate that here, because we can't guarantee that 'endpoint' > is set before 'username' is set. >=20 >=20 > We could enforce it in the setter for the "loaded" property as that is > set only after every other property is set. As far as I can see we could only warn here, since the set_loaded function returns void. Rich. --=20 Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rj= ones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top