From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYcGn-0001lg-Mi for qemu-devel@nongnu.org; Thu, 28 Jun 2018 15:08:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYcGe-0001Vd-VY for qemu-devel@nongnu.org; Thu, 28 Jun 2018 15:07:53 -0400 From: Eric Blake Date: Thu, 28 Jun 2018 14:07:20 -0500 Message-Id: <20180628190723.276458-4-eblake@redhat.com> In-Reply-To: <20180628190723.276458-1-eblake@redhat.com> References: <20180628190723.276458-1-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v7 3/6] qcow2: Reduce REFT_OFFSET_MASK List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org, berto@igalia.com Match our code to the spec change in the previous patch - there's no reason for the refcount table to allow larger offsets than the L1/L2 tables. In practice, no image has more than 64PB of allocated clusters anyways, as anything beyond that can't be expressed via L2 mappings to host offsets. Suggested-by: Alberto Garcia Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia --- v4: new patch --- block/qcow2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.h b/block/qcow2.h index 01b5250415f..3774229ef9c 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@ -439,7 +439,7 @@ typedef enum QCow2MetadataOverlap { #define L2E_OFFSET_MASK 0x00fffffffffffe00ULL #define L2E_COMPRESSED_OFFSET_SIZE_MASK 0x3fffffffffffffffULL -#define REFT_OFFSET_MASK 0xfffffffffffffe00ULL +#define REFT_OFFSET_MASK 0x00fffffffffffe00ULL static inline int64_t start_of_cluster(BDRVQcow2State *s, int64_t offset) { -- 2.14.4