From: Kevin Wolf <kwolf@redhat.com>
To: Ari Sundholm <ari@tuxera.com>
Cc: qemu-devel@nongnu.org, Aapo Vienamo <aapo@tuxera.com>,
Max Reitz <mreitz@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v5 8/8] block: Add blklogwrites
Date: Fri, 29 Jun 2018 18:31:36 +0200 [thread overview]
Message-ID: <20180629163136.GJ15588@localhost.localdomain> (raw)
In-Reply-To: <a7f5ceaa-41ed-d732-67e9-dfd25abe6abd@tuxera.com>
Am 29.06.2018 um 18:02 hat Ari Sundholm geschrieben:
> On 06/29/2018 03:05 PM, Kevin Wolf wrote:
> > Am 19.06.2018 um 15:43 hat Ari Sundholm geschrieben:
> > > + s->cur_log_sector = 1;
> > > + s->nr_entries = 0;
> >
> > Would it be useful to implement a mode that appends to the log?
> >
> > In that case, you'd obviously use the sector size from the existing
> > superblock instead of allowing the user to specify something else.
> >
>
> Such a mode may indeed be useful. Thank you for the idea. Would it be OK to
> introduce this feature as a separate patch a bit later?
Yes, of course.
> > > +static BlockDriver bdrv_blk_log_writes = {
> > > + .format_name = "blklogwrites",
> > > + .protocol_name = "blklogwrites",
> >
> > This is for the blklogwrites:X:Y syntax, which is not supported, so it
> > should be removed.
> >
>
> Just protocol_name, I assume? Will remove, thanks.
Right, just protocol_name. format_name is always required.
Kevin
next prev parent reply other threads:[~2018-06-29 16:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:43 [Qemu-devel] [PATCH v5 0/8] New block driver: blklogwrites Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 1/8] block: Move two block permission constants to the relevant enum Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 2/8] block: Add a mechanism for passing a block driver a block configuration Ari Sundholm
2018-06-29 10:07 ` Kevin Wolf
2018-06-29 15:36 ` Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 3/8] hw/scsi/scsi-disk: Always apply block configuration to block driver Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 4/8] hw/ide/qdev: " Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 5/8] hw/block/virtio-blk: " Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 6/8] hw/block/nvme: " Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 7/8] hw/block/fdc: " Ari Sundholm
2018-06-19 13:43 ` [Qemu-devel] [PATCH v5 8/8] block: Add blklogwrites Ari Sundholm
2018-06-29 12:05 ` Kevin Wolf
2018-06-29 16:02 ` Ari Sundholm
2018-06-29 16:31 ` Kevin Wolf [this message]
2018-06-26 18:06 ` [Qemu-devel] [PATCH v5 0/8] New block driver: blklogwrites Ari Sundholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629163136.GJ15588@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=aapo@tuxera.com \
--cc=ari@tuxera.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).