qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PULL 10/11] hw/block/fdc: Convert from FLOPPY_DPRINTF() macro to trace events
Date: Fri, 29 Jun 2018 18:53:29 +0100	[thread overview]
Message-ID: <20180629175330.19391-11-stefanha@redhat.com> (raw)
In-Reply-To: <20180629175330.19391-1-stefanha@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/block/fdc.c        | 6 +++---
 hw/block/trace-events | 4 ++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/hw/block/fdc.c b/hw/block/fdc.c
index cd29e27d8f..c7b4fe9b3e 100644
--- a/hw/block/fdc.c
+++ b/hw/block/fdc.c
@@ -40,6 +40,7 @@
 #include "sysemu/blockdev.h"
 #include "sysemu/sysemu.h"
 #include "qemu/log.h"
+#include "trace.h"
 
 /********************************************************/
 /* debug Floppy devices */
@@ -934,7 +935,7 @@ static uint32_t fdctrl_read (void *opaque, uint32_t reg)
         retval = (uint32_t)(-1);
         break;
     }
-    FLOPPY_DPRINTF("read reg%d: 0x%02x\n", reg & 7, retval);
+    trace_fdc_ioport_read(reg, retval);
 
     return retval;
 }
@@ -943,9 +944,8 @@ static void fdctrl_write (void *opaque, uint32_t reg, uint32_t value)
 {
     FDCtrl *fdctrl = opaque;
 
-    FLOPPY_DPRINTF("write reg%d: 0x%02x\n", reg & 7, value);
-
     reg &= 7;
+    trace_fdc_ioport_write(reg, value);
     switch (reg) {
     case FD_REG_DOR:
         fdctrl_write_dor(fdctrl, value);
diff --git a/hw/block/trace-events b/hw/block/trace-events
index 6b9e733412..d842c45409 100644
--- a/hw/block/trace-events
+++ b/hw/block/trace-events
@@ -1,5 +1,9 @@
 # See docs/devel/tracing.txt for syntax documentation.
 
+# hw/block/fdc.c
+fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x"
+fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x"
+
 # hw/block/virtio-blk.c
 virtio_blk_req_complete(void *vdev, void *req, int status) "vdev %p req %p status %d"
 virtio_blk_rw_complete(void *vdev, void *req, int ret) "vdev %p req %p ret %d"
-- 
2.17.1

  parent reply	other threads:[~2018-06-29 17:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 17:53 [Qemu-devel] [PULL 00/11] Tracing patches Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 01/11] simpletrace: Convert name from mapping record to str Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 02/11] trace: Fix format string for the struct timeval members casted to size_t Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 03/11] sdcard: Reduce sdcard_set_blocklen() trace digits Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 04/11] hw/char/serial: Convert from DPRINTF macro to trace events Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 05/11] hw/char/parallel: Convert from pdebug() " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 06/11] hw/input/tsc2005: Convert a fprintf() call " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 07/11] hw/net/ne2000: Add " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 08/11] hw/net/ne2000: Convert printf() calls to " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 09/11] hw/net/etraxfs_eth: " Stefan Hajnoczi
2018-06-29 17:53 ` Stefan Hajnoczi [this message]
2018-06-29 17:53 ` [Qemu-devel] [PULL 11/11] hw/block/pflash_cfi: Convert from DPRINTF() macro " Stefan Hajnoczi
2018-06-30 14:04 ` [Qemu-devel] [PULL 00/11] Tracing patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180629175330.19391-11-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).