From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PULL 03/11] sdcard: Reduce sdcard_set_blocklen() trace digits
Date: Fri, 29 Jun 2018 18:53:22 +0100 [thread overview]
Message-ID: <20180629175330.19391-4-stefanha@redhat.com> (raw)
In-Reply-To: <20180629175330.19391-1-stefanha@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Per the Physical Layer Simplified Spec. "5.3 CSD Register":
"The maximum block length might therefore be in the range 512...2048 bytes"
Therefore 3 hexdigits are enough to report the block length.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/sd/trace-events | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/trace-events b/hw/sd/trace-events
index bfd1d62efc..d7880bcea5 100644
--- a/hw/sd/trace-events
+++ b/hw/sd/trace-events
@@ -37,7 +37,7 @@ sdcard_powerup(void) ""
sdcard_inquiry_cmd41(void) ""
sdcard_set_enable(bool current_state, bool new_state) "%u -> %u"
sdcard_reset(void) ""
-sdcard_set_blocklen(uint16_t length) "0x%04x"
+sdcard_set_blocklen(uint16_t length) "0x%03x"
sdcard_inserted(bool readonly) "read_only: %u"
sdcard_ejected(void) ""
sdcard_erase(void) ""
--
2.17.1
next prev parent reply other threads:[~2018-06-29 17:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 17:53 [Qemu-devel] [PULL 00/11] Tracing patches Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 01/11] simpletrace: Convert name from mapping record to str Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 02/11] trace: Fix format string for the struct timeval members casted to size_t Stefan Hajnoczi
2018-06-29 17:53 ` Stefan Hajnoczi [this message]
2018-06-29 17:53 ` [Qemu-devel] [PULL 04/11] hw/char/serial: Convert from DPRINTF macro to trace events Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 05/11] hw/char/parallel: Convert from pdebug() " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 06/11] hw/input/tsc2005: Convert a fprintf() call " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 07/11] hw/net/ne2000: Add " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 08/11] hw/net/ne2000: Convert printf() calls to " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 09/11] hw/net/etraxfs_eth: " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 10/11] hw/block/fdc: Convert from FLOPPY_DPRINTF() macro " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 11/11] hw/block/pflash_cfi: Convert from DPRINTF() " Stefan Hajnoczi
2018-06-30 14:04 ` [Qemu-devel] [PULL 00/11] Tracing patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629175330.19391-4-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).