From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PULL 06/11] hw/input/tsc2005: Convert a fprintf() call to trace events
Date: Fri, 29 Jun 2018 18:53:25 +0100 [thread overview]
Message-ID: <20180629175330.19391-7-stefanha@redhat.com> (raw)
In-Reply-To: <20180629175330.19391-1-stefanha@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/input/tsc2005.c | 7 +++----
hw/input/trace-events | 3 +++
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c
index 4dd95596ab..2b9108a193 100644
--- a/hw/input/tsc2005.c
+++ b/hw/input/tsc2005.c
@@ -24,6 +24,7 @@
#include "qemu/timer.h"
#include "ui/console.h"
#include "hw/devices.h"
+#include "trace.h"
#define TSC_CUT_RESOLUTION(value, p) ((value) >> (16 - (p ? 12 : 10)))
@@ -201,8 +202,7 @@ static void tsc2005_write(TSC2005State *s, int reg, uint16_t data)
s->host_mode = (data >> 15) != 0;
if (s->enabled != !(data & 0x4000)) {
s->enabled = !(data & 0x4000);
- fprintf(stderr, "%s: touchscreen sense %sabled\n",
- __func__, s->enabled ? "en" : "dis");
+ trace_tsc2005_sense(s->enabled ? "enabled" : "disabled");
if (s->busy && !s->enabled)
timer_del(s->timer);
s->busy = s->busy && s->enabled;
@@ -340,8 +340,7 @@ static uint8_t tsc2005_txrx_word(void *opaque, uint8_t value)
s->nextprecision = (value >> 2) & 1;
if (s->enabled != !(value & 1)) {
s->enabled = !(value & 1);
- fprintf(stderr, "%s: touchscreen sense %sabled\n",
- __func__, s->enabled ? "en" : "dis");
+ trace_tsc2005_sense(s->enabled ? "enabled" : "disabled");
if (s->busy && !s->enabled)
timer_del(s->timer);
s->busy = s->busy && s->enabled;
diff --git a/hw/input/trace-events b/hw/input/trace-events
index db72484a25..3965a842ae 100644
--- a/hw/input/trace-events
+++ b/hw/input/trace-events
@@ -41,5 +41,8 @@ milkymist_softusb_pulse_irq(void) "Pulse IRQ"
hid_kbd_queue_full(void) "queue full"
hid_kbd_queue_empty(void) "queue empty"
+# hw/input/tsc2005.c
+tsc2005_sense(const char *state) "touchscreen sense %s"
+
# hw/input/virtio
virtio_input_queue_full(void) "queue full"
--
2.17.1
next prev parent reply other threads:[~2018-06-29 17:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 17:53 [Qemu-devel] [PULL 00/11] Tracing patches Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 01/11] simpletrace: Convert name from mapping record to str Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 02/11] trace: Fix format string for the struct timeval members casted to size_t Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 03/11] sdcard: Reduce sdcard_set_blocklen() trace digits Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 04/11] hw/char/serial: Convert from DPRINTF macro to trace events Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 05/11] hw/char/parallel: Convert from pdebug() " Stefan Hajnoczi
2018-06-29 17:53 ` Stefan Hajnoczi [this message]
2018-06-29 17:53 ` [Qemu-devel] [PULL 07/11] hw/net/ne2000: Add " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 08/11] hw/net/ne2000: Convert printf() calls to " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 09/11] hw/net/etraxfs_eth: " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 10/11] hw/block/fdc: Convert from FLOPPY_DPRINTF() macro " Stefan Hajnoczi
2018-06-29 17:53 ` [Qemu-devel] [PULL 11/11] hw/block/pflash_cfi: Convert from DPRINTF() " Stefan Hajnoczi
2018-06-30 14:04 ` [Qemu-devel] [PULL 00/11] Tracing patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629175330.19391-7-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).