qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PULL 26/47] hw/microblaze: Use the IEC binary prefix definitions
Date: Sat, 30 Jun 2018 08:10:19 +0200	[thread overview]
Message-ID: <20180630061040.6018-27-pbonzini@redhat.com> (raw)
In-Reply-To: <20180630061040.6018-1-pbonzini@redhat.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

It eases code review, unit is explicit.

Patch generated using:

  $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/

and modified manually.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20180625124238.25339-25-f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/microblaze/petalogix_ml605_mmu.c      | 7 ++++---
 hw/microblaze/petalogix_s3adsp1800_mmu.c | 7 ++++---
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
index 6c4a544..c730878 100644
--- a/hw/microblaze/petalogix_ml605_mmu.c
+++ b/hw/microblaze/petalogix_ml605_mmu.c
@@ -26,6 +26,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/units.h"
 #include "qapi/error.h"
 #include "qemu-common.h"
 #include "cpu.h"
@@ -44,8 +45,8 @@
 
 #include "hw/stream.h"
 
-#define LMB_BRAM_SIZE  (128 * 1024)
-#define FLASH_SIZE     (32 * 1024 * 1024)
+#define LMB_BRAM_SIZE  (128 * KiB)
+#define FLASH_SIZE     (32 * MiB)
 
 #define BINARY_DEVICE_TREE_FILE "petalogix-ml605.dtb"
 
@@ -109,7 +110,7 @@ petalogix_ml605_init(MachineState *machine)
     pflash_cfi01_register(FLASH_BASEADDR,
                           NULL, "petalogix_ml605.flash", FLASH_SIZE,
                           dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
-                          (64 * 1024), FLASH_SIZE >> 16,
+                          64 * KiB, FLASH_SIZE >> 16,
                           2, 0x89, 0x18, 0x0000, 0x0, 0);
 
 
diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petalogix_s3adsp1800_mmu.c
index 0da3e62..5cf7b84 100644
--- a/hw/microblaze/petalogix_s3adsp1800_mmu.c
+++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
@@ -24,6 +24,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/units.h"
 #include "qapi/error.h"
 #include "qemu-common.h"
 #include "cpu.h"
@@ -39,8 +40,8 @@
 
 #include "boot.h"
 
-#define LMB_BRAM_SIZE  (128 * 1024)
-#define FLASH_SIZE     (16 * 1024 * 1024)
+#define LMB_BRAM_SIZE  (128 * KiB)
+#define FLASH_SIZE     (16 * MiB)
 
 #define BINARY_DEVICE_TREE_FILE "petalogix-s3adsp1800.dtb"
 
@@ -87,7 +88,7 @@ petalogix_s3adsp1800_init(MachineState *machine)
     pflash_cfi01_register(FLASH_BASEADDR,
                           NULL, "petalogix_s3adsp1800.flash", FLASH_SIZE,
                           dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
-                          (64 * 1024), FLASH_SIZE >> 16,
+                          64 * KiB, FLASH_SIZE >> 16,
                           1, 0x89, 0x18, 0x0000, 0x0, 1);
 
     dev = qdev_create(NULL, "xlnx.xps-intc");
-- 
1.8.3.1

  parent reply	other threads:[~2018-06-30  6:11 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-30  6:09 [Qemu-devel] [PULL 00/47] More misc patches for 3.0 soft freeze Paolo Bonzini
2018-06-30  6:09 ` [Qemu-devel] [PULL 01/47] i386/kvm: add support for Hyper-V TLB flush Paolo Bonzini
2018-06-30  6:09 ` [Qemu-devel] [PULL 02/47] configure: add sanity check to catch builds from "git archive" Paolo Bonzini
2018-06-30  6:09 ` [Qemu-devel] [PULL 03/47] include: Add IEC binary prefixes in "qemu/units.h" Paolo Bonzini
2018-06-30  6:09 ` [Qemu-devel] [PULL 04/47] vdi: Use definitions from "qemu/units.h" Paolo Bonzini
2018-06-30  6:09 ` [Qemu-devel] [PULL 05/47] x86/cpu: " Paolo Bonzini
2018-06-30  6:09 ` [Qemu-devel] [PULL 06/47] checkpatch: Recognize IEC binary prefix definitions Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 07/47] hw: Use IEC binary prefix definitions from "qemu/units.h" Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 08/47] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h" Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 09/47] hw/ivshmem: Use the IEC binary prefix definitions Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 10/47] hw/ipack: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 11/47] hw/scsi: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 12/47] hw/smbios: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 13/47] hw/xen: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 14/47] hw/tpm: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 15/47] hw/block: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 16/47] hw/display: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 17/47] hw/misc: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 18/47] hw/riscv: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 19/47] hw/m68k: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 20/47] hw/sparc: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 21/47] hw/s390x: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 22/47] hw/hppa: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 23/47] hw/xtensa: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 24/47] hw/alpha: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 25/47] hw/tricore: " Paolo Bonzini
2018-06-30  6:10 ` Paolo Bonzini [this message]
2018-06-30  6:10 ` [Qemu-devel] [PULL 27/47] hw/nios2: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 28/47] hw/cris: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 29/47] hw/lm32: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 30/47] hw/sh4: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 31/47] hw/mips/r4k: Constify params_size Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 32/47] hw/mips: Use the IEC binary prefix definitions Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 33/47] hw/ppc: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 34/47] hw/i386: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 35/47] hw/net: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 36/47] hw/usb: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 37/47] hw/sd: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 38/47] hw/vfio: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 39/47] hw/virtio: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 40/47] hw/rdma: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 41/47] cutils: Do not include "qemu/units.h" directly Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 42/47] monitor: Use the IEC binary prefix definitions Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 43/47] vl: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 44/47] tests/crypto: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 45/47] linux-user: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 46/47] bsd-user: " Paolo Bonzini
2018-06-30  6:10 ` [Qemu-devel] [PULL 47/47] serial: Open non-block Paolo Bonzini
2018-06-30 15:39 ` [Qemu-devel] [PULL 00/47] More misc patches for 3.0 soft freeze Peter Maydell
2018-06-30 15:51   ` Paolo Bonzini
2018-06-30 16:50     ` [Qemu-devel] [PATCH] !fixup 052f529eb3d07170b18b8d0920bc8c450e389a2f Philippe Mathieu-Daudé
2018-07-02  8:37       ` Paolo Bonzini
2018-07-02 13:32       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180630061040.6018-27-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).