From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PULL 04/47] vdi: Use definitions from "qemu/units.h"
Date: Sat, 30 Jun 2018 08:09:57 +0200 [thread overview]
Message-ID: <20180630061040.6018-5-pbonzini@redhat.com> (raw)
In-Reply-To: <20180630061040.6018-1-pbonzini@redhat.com>
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20180625124238.25339-3-f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/vdi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index 1d8ed67..6555cff 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -50,6 +50,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/units.h"
#include "qapi/error.h"
#include "qapi/qobject-input-visitor.h"
#include "qapi/qapi-visit-block-core.h"
@@ -83,9 +84,6 @@
/* Command line option for static images. */
#define BLOCK_OPT_STATIC "static"
-#define KiB 1024
-#define MiB (KiB * KiB)
-
#define SECTOR_SIZE 512
#define DEFAULT_CLUSTER_SIZE (1 * MiB)
@@ -434,7 +432,8 @@ static int vdi_open(BlockDriverState *bs, QDict *options, int flags,
goto fail;
} else if (header.block_size != DEFAULT_CLUSTER_SIZE) {
error_setg(errp, "unsupported VDI image (block size %" PRIu32
- " is not %u)", header.block_size, DEFAULT_CLUSTER_SIZE);
+ " is not %" PRIu64 ")",
+ header.block_size, DEFAULT_CLUSTER_SIZE);
ret = -ENOTSUP;
goto fail;
} else if (header.disk_size >
--
1.8.3.1
next prev parent reply other threads:[~2018-06-30 6:10 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 6:09 [Qemu-devel] [PULL 00/47] More misc patches for 3.0 soft freeze Paolo Bonzini
2018-06-30 6:09 ` [Qemu-devel] [PULL 01/47] i386/kvm: add support for Hyper-V TLB flush Paolo Bonzini
2018-06-30 6:09 ` [Qemu-devel] [PULL 02/47] configure: add sanity check to catch builds from "git archive" Paolo Bonzini
2018-06-30 6:09 ` [Qemu-devel] [PULL 03/47] include: Add IEC binary prefixes in "qemu/units.h" Paolo Bonzini
2018-06-30 6:09 ` Paolo Bonzini [this message]
2018-06-30 6:09 ` [Qemu-devel] [PULL 05/47] x86/cpu: Use definitions from "qemu/units.h" Paolo Bonzini
2018-06-30 6:09 ` [Qemu-devel] [PULL 06/47] checkpatch: Recognize IEC binary prefix definitions Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 07/47] hw: Use IEC binary prefix definitions from "qemu/units.h" Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 08/47] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h" Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 09/47] hw/ivshmem: Use the IEC binary prefix definitions Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 10/47] hw/ipack: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 11/47] hw/scsi: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 12/47] hw/smbios: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 13/47] hw/xen: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 14/47] hw/tpm: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 15/47] hw/block: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 16/47] hw/display: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 17/47] hw/misc: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 18/47] hw/riscv: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 19/47] hw/m68k: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 20/47] hw/sparc: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 21/47] hw/s390x: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 22/47] hw/hppa: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 23/47] hw/xtensa: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 24/47] hw/alpha: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 25/47] hw/tricore: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 26/47] hw/microblaze: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 27/47] hw/nios2: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 28/47] hw/cris: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 29/47] hw/lm32: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 30/47] hw/sh4: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 31/47] hw/mips/r4k: Constify params_size Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 32/47] hw/mips: Use the IEC binary prefix definitions Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 33/47] hw/ppc: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 34/47] hw/i386: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 35/47] hw/net: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 36/47] hw/usb: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 37/47] hw/sd: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 38/47] hw/vfio: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 39/47] hw/virtio: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 40/47] hw/rdma: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 41/47] cutils: Do not include "qemu/units.h" directly Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 42/47] monitor: Use the IEC binary prefix definitions Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 43/47] vl: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 44/47] tests/crypto: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 45/47] linux-user: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 46/47] bsd-user: " Paolo Bonzini
2018-06-30 6:10 ` [Qemu-devel] [PULL 47/47] serial: Open non-block Paolo Bonzini
2018-06-30 15:39 ` [Qemu-devel] [PULL 00/47] More misc patches for 3.0 soft freeze Peter Maydell
2018-06-30 15:51 ` Paolo Bonzini
2018-06-30 16:50 ` [Qemu-devel] [PATCH] !fixup 052f529eb3d07170b18b8d0920bc8c450e389a2f Philippe Mathieu-Daudé
2018-07-02 8:37 ` Paolo Bonzini
2018-07-02 13:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180630061040.6018-5-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).