qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Richard Henderson <rth@twiddle.net>,
	David Hildenbrand <david@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PULL 03/15] s390x/cpumodel: default enable bpb and ppa15 for z196 and later
Date: Mon,  2 Jul 2018 13:17:25 +0200	[thread overview]
Message-ID: <20180702111737.18970-4-cohuck@redhat.com> (raw)
In-Reply-To: <20180702111737.18970-1-cohuck@redhat.com>

From: Christian Borntraeger <borntraeger@de.ibm.com>

Most systems and host kernels provide the necessary building blocks for
bpb and ppa15. We can reverse the logic and default enable those
features, while still allowing to disable it via cpu model.

So let us add bpb and ppa15 to z196 and later default CPU model for the
qemu 3.0 machine. (like -cpu z13).  Older machine types (e.g.
s390-ccw-virtio-2.12) will retain the old value and not provide those
bits in the default model.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Message-Id: <20180626123830.18282-1-borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/s390-virtio-ccw.c  | 2 ++
 target/s390x/gen-features.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 7ae5fb38dd..f8f58c8acb 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -824,6 +824,8 @@ DEFINE_CCW_MACHINE(3_0, "3.0", true);
 static void ccw_machine_2_12_instance_options(MachineState *machine)
 {
     ccw_machine_3_0_instance_options(machine);
+    s390_cpudef_featoff_greater(11, 1, S390_FEAT_PPA15);
+    s390_cpudef_featoff_greater(11, 1, S390_FEAT_BPB);
 }
 
 static void ccw_machine_2_12_class_options(MachineClass *mc)
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 0cdbc15378..6626b6f565 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -512,6 +512,8 @@ static uint16_t default_GEN11_GA1[] = {
     S390_FEAT_IPTE_RANGE,
     S390_FEAT_ACCESS_EXCEPTION_FS_INDICATION,
     S390_FEAT_GROUP_MSA_EXT_4,
+    S390_FEAT_PPA15,
+    S390_FEAT_BPB,
 };
 
 #define default_GEN11_GA2 EmptyFeat
-- 
2.14.4

  parent reply	other threads:[~2018-07-02 11:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 11:17 [Qemu-devel] [PULL 00/15] s390x patches for 3.0 Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 01/15] s390/ipl: fix ipl with -no-reboot Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 02/15] loader: Check access size when calling rom_ptr() to avoid crashes Cornelia Huck
2018-07-02 11:17 ` Cornelia Huck [this message]
2018-07-02 11:17 ` [Qemu-devel] [PULL 04/15] s390x/tcg: avoid overflows in time2tod/tod2time Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 05/15] s390x/kvm: pass values instead of pointers to kvm_s390_set_clock_*() Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 06/15] s390x/tod: factor out TOD into separate device Cornelia Huck
2018-10-11 12:15   ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-10-11 12:32     ` Cornelia Huck
2018-10-11 12:35       ` David Hildenbrand
2018-07-02 11:17 ` [Qemu-devel] [PULL 07/15] s390x/tcg: drop tod_basetime Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 08/15] s390x/tcg: properly implement the TOD Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 09/15] s390x/tcg: SET CLOCK COMPARATOR can clear CKC interrupts Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 10/15] s390x/tcg: implement SET CLOCK Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 11/15] s390x/tcg: rearm the CKC timer during migration Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 12/15] s390x/tcg: fix CPU hotplug with single-threaded TCG Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 13/15] s390x/kvm: legacy_s390_alloc() only supports one allocation Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 14/15] s390x/kvm: indicate alignment in legacy_s390_alloc() Cornelia Huck
2018-07-02 11:17 ` [Qemu-devel] [PULL 15/15] s390x/tcg: fix locking problem with tcg_s390_tod_updated Cornelia Huck
2018-07-02 15:07 ` [Qemu-devel] [PULL 00/15] s390x patches for 3.0 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180702111737.18970-4-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).