From: Igor Mammedov <imammedo@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v1] machine: properly free device_memory
Date: Mon, 2 Jul 2018 12:32:30 +0200 [thread overview]
Message-ID: <20180702123230.17efcc84@redhat.com> (raw)
In-Reply-To: <20180702094152.7882-1-david@redhat.com>
On Mon, 2 Jul 2018 11:41:52 +0200
David Hildenbrand <david@redhat.com> wrote:
> Machines might have inititalized device_memory if they support memory
> devices, so let's properly free it.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> hw/core/machine.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 617e5f8d75..ae3e713e90 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -674,6 +674,7 @@ static void machine_finalize(Object *obj)
> g_free(ms->dumpdtb);
> g_free(ms->dt_compatible);
> g_free(ms->firmware);
> + g_free(ms->device_memory);
> }
>
> bool machine_usb(MachineState *machine)
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
next prev parent reply other threads:[~2018-07-02 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 9:41 [Qemu-devel] [PATCH v1] machine: properly free device_memory David Hildenbrand
2018-07-02 10:32 ` Igor Mammedov [this message]
2018-07-02 21:43 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702123230.17efcc84@redhat.com \
--to=imammedo@redhat.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).