* [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it is not needed
@ 2018-06-30 16:54 Michael Tokarev
2018-06-30 17:06 ` Philippe Mathieu-Daudé
2018-07-02 15:45 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Michael Tokarev @ 2018-06-30 16:54 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Tokarev, Gerd Hoffmann
Opengl support brings up libdrm. But actually nothing uses this library
or includes any of its headers. Just remove checking for it from configure.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 65548df1fc..951ff022dd 100755
--- a/configure
+++ b/configure
@@ -3865,7 +3865,7 @@ libs_softmmu="$libs_softmmu $fdt_libs"
# opengl probe (for sdl2, gtk, milkymist-tmu2)
if test "$opengl" != "no" ; then
- opengl_pkgs="epoxy libdrm gbm"
+ opengl_pkgs="epoxy gbm"
if $pkg_config $opengl_pkgs; then
opengl_cflags="$($pkg_config --cflags $opengl_pkgs)"
opengl_libs="$($pkg_config --libs $opengl_pkgs)"
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it is not needed
2018-06-30 16:54 [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it is not needed Michael Tokarev
@ 2018-06-30 17:06 ` Philippe Mathieu-Daudé
2018-07-02 15:45 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-06-30 17:06 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: Gerd Hoffmann
On 06/30/2018 01:54 PM, Michael Tokarev wrote:
> Opengl support brings up libdrm. But actually nothing uses this library
> or includes any of its headers. Just remove checking for it from configure.
libgbm is linked to libdrm, but I don't see call from QEMU to libdrm,
son we don't need to check for it (and his headers) indeed.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 65548df1fc..951ff022dd 100755
> --- a/configure
> +++ b/configure
> @@ -3865,7 +3865,7 @@ libs_softmmu="$libs_softmmu $fdt_libs"
> # opengl probe (for sdl2, gtk, milkymist-tmu2)
>
> if test "$opengl" != "no" ; then
> - opengl_pkgs="epoxy libdrm gbm"
> + opengl_pkgs="epoxy gbm"
> if $pkg_config $opengl_pkgs; then
> opengl_cflags="$($pkg_config --cflags $opengl_pkgs)"
> opengl_libs="$($pkg_config --libs $opengl_pkgs)"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it is not needed
2018-06-30 16:54 [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it is not needed Michael Tokarev
2018-06-30 17:06 ` Philippe Mathieu-Daudé
@ 2018-07-02 15:45 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2018-07-02 15:45 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-devel
On Sat, Jun 30, 2018 at 07:54:48PM +0300, Michael Tokarev wrote:
> Opengl support brings up libdrm. But actually nothing uses this library
> or includes any of its headers. Just remove checking for it from configure.
Added to ui queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-02 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-30 16:54 [Qemu-devel] [PATCH] ui: do not build-depend or link with libdrm, it is not needed Michael Tokarev
2018-06-30 17:06 ` Philippe Mathieu-Daudé
2018-07-02 15:45 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).