Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1651 bytes --]

On Mon, Jul 02, 2018 at 06:02:07PM -0400, Emilio G. Cota wrote:
> The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert
> to TranslatorOps", 2018-02-16).
> 
> Fix it by setting is_jmp, so that we break from the translation loop
> as originally intended.
> 
> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> (I'll send this to qemu-stable (for 2.12) once it's on master.)

Applied to ppc-for-3.0.  It's kind of lucky I happened to pick this up
on qemu-ppc - I'm not able to read that all the time.  Things will get
merged much faster if you CC me directly on things to go through the
ppc tree.

> ---
>  target/ppc/translate.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 3a215a1..99c2731 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -7314,6 +7314,7 @@ static bool ppc_tr_breakpoint_check(DisasContextBase *dcbase, CPUState *cs,
>      DisasContext *ctx = container_of(dcbase, DisasContext, base);
>  
>      gen_debug_exception(ctx);
> +    dcbase->is_jmp = DISAS_NORETURN;
>      /* The address covered by the breakpoint must be included in
>         [tb->pc, tb->pc + tb->size) in order to for it to be
>         properly cleared -- thus we increment the PC here so that

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]