From: David Gibson <david@gibson.dropbear.id.au>
To: "Emilio G. Cota" <cota@braap.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check
Date: Tue, 3 Jul 2018 13:31:56 +1000 [thread overview]
Message-ID: <20180703033156.GK3422@umbus.fritz.box> (raw)
In-Reply-To: <20180703032257.GA29222@flamenco>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On Mon, Jul 02, 2018 at 11:22:57PM -0400, Emilio G. Cota wrote:
> On Tue, Jul 03, 2018 at 11:03:48 +1000, David Gibson wrote:
> > On Mon, Jul 02, 2018 at 06:02:07PM -0400, Emilio G. Cota wrote:
> > > The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert
> > > to TranslatorOps", 2018-02-16).
> > >
> > > Fix it by setting is_jmp, so that we break from the translation loop
> > > as originally intended.
> > >
> > > Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > > Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > > Signed-off-by: Emilio G. Cota <cota@braap.org>
> > > ---
> > > (I'll send this to qemu-stable (for 2.12) once it's on master.)
> >
> > Applied to ppc-for-3.0. It's kind of lucky I happened to pick this up
> > on qemu-ppc - I'm not able to read that all the time. Things will get
> > merged much faster if you CC me directly on things to go through the
> > ppc tree.
>
> Sorry I forgot to Cc you -- will do better next time.
Great, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-07-03 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:02 [Qemu-devel] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check Emilio G. Cota
2018-07-03 1:03 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2018-07-03 3:22 ` Emilio G. Cota
2018-07-03 3:31 ` David Gibson [this message]
2018-07-03 3:42 ` [Qemu-devel] " no-reply
2018-07-04 19:53 ` [Qemu-devel] [PATCH for-2.12.1] " Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703033156.GK3422@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).