qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org,
	clg@kaod.org, agraf@suse.de, mdroth@linux.vnet.ibm.com,
	aik@ozlabs.ru, Guenter Roeck <linux@roeck-us.net>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 03/35] sam460ex: Fix sam460ex device tree when booting the Linux kernel
Date: Tue,  3 Jul 2018 15:57:32 +1000	[thread overview]
Message-ID: <20180703055804.13449-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20180703055804.13449-1-david@gibson.dropbear.id.au>

From: Guenter Roeck <linux@roeck-us.net>

sam460ex (or at least this emulation) does not support the "ibm,cpm" power
management. As a result, Linux crashes when trying to access it. Remove
its device tree node. Also, if/when we boot the Linux kernel directly,
serial port clock frequencies in the device tree file will be unset, and
serial port initialization will fail. Add valid frequency values to
the serial ports to be able to use it. Also set valid values for the other
clock nodes otherwise set by u-boot.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/sam460ex.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c
index bdc53d2603..33ea51816c 100644
--- a/hw/ppc/sam460ex.c
+++ b/hw/ppc/sam460ex.c
@@ -37,6 +37,8 @@
 #include "hw/i2c/smbus.h"
 #include "hw/usb/hcd-ehci.h"
 
+#include <libfdt.h>
+
 #define BINARY_DEVICE_TREE_FILE "canyonlands.dtb"
 #define UBOOT_FILENAME "u-boot-sam460-20100605.bin"
 /* to extract the official U-Boot bin from the updater: */
@@ -67,6 +69,10 @@
 */
 
 #define CPU_FREQ 1150000000
+#define PLB_FREQ 230000000
+#define OPB_FREQ 115000000
+#define EBC_FREQ 115000000
+#define UART_FREQ 11059200
 #define SDRAM_NR_BANKS 4
 
 /* FIXME: See u-boot.git 8ac41e, also fix in ppc440_uc.c */
@@ -255,6 +261,7 @@ static int sam460ex_load_device_tree(hwaddr addr,
     void *fdt;
     uint32_t tb_freq = CPU_FREQ;
     uint32_t clock_freq = CPU_FREQ;
+    int offset;
 
     filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, BINARY_DEVICE_TREE_FILE);
     if (!filename) {
@@ -308,6 +315,27 @@ static int sam460ex_load_device_tree(hwaddr addr,
     qemu_fdt_setprop_cell(fdt, "/cpus/cpu@0", "timebase-frequency",
                               tb_freq);
 
+    /* Remove cpm node if it exists (it is not emulated) */
+    offset = fdt_path_offset(fdt, "/cpm");
+    if (offset >= 0) {
+        fdt_nop_node(fdt, offset);
+    }
+
+    /* set serial port clocks */
+    offset = fdt_node_offset_by_compatible(fdt, -1, "ns16550");
+    while (offset >= 0) {
+        fdt_setprop_cell(fdt, offset, "clock-frequency", UART_FREQ);
+        offset = fdt_node_offset_by_compatible(fdt, offset, "ns16550");
+    }
+
+    /* some more clocks */
+    qemu_fdt_setprop_cell(fdt, "/plb", "clock-frequency",
+                              PLB_FREQ);
+    qemu_fdt_setprop_cell(fdt, "/plb/opb", "clock-frequency",
+                              OPB_FREQ);
+    qemu_fdt_setprop_cell(fdt, "/plb/opb/ebc", "clock-frequency",
+                              EBC_FREQ);
+
     rom_add_blob_fixed(BINARY_DEVICE_TREE_FILE, fdt, fdt_size, addr);
     g_free(fdt);
     ret = fdt_size;
-- 
2.17.1

  parent reply	other threads:[~2018-07-03  5:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03  5:57 [Qemu-devel] [PULL 00/35] ppc-for-3.0 queue 20180703 David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 01/35] mac_dbdma: only dump commands for debug enabled channels David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 02/35] mac_newworld: always enable disable_direct_reg3_writes for ADB machines David Gibson
2018-07-03  5:57 ` David Gibson [this message]
2018-07-03  5:57 ` [Qemu-devel] [PULL 04/35] ppc/xics: introduce ICP DeviceRealize and DeviceReset handlers David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 05/35] ppc/xics: introduce a parent_realize in ICSStateClass David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 06/35] ppc/xics: move the instance_init handler under the ics-base class David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 07/35] ppx/xics: introduce a parent_reset in ICSStateClass David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 08/35] ppc/xics: move the vmstate structures under the ics-base class David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 09/35] ppc/xics: rework the ICS classes inheritance tree David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 10/35] ppc/pnv: fix pnv_core_realize() error handling David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 11/35] target/ppc: Add do_unaligned_access hook David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 12/35] target/ppc: Use atomic load for LQ and LQARX David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 13/35] target/ppc: Use atomic store for STQ David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 14/35] target/ppc: Use atomic cmpxchg for STQCX David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 15/35] target/ppc: Remove POWERPC_EXCP_STCX David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 16/35] target/ppc: Tidy gen_conditional_store David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 17/35] target/ppc: Split out gen_load_locked David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 18/35] target/ppc: Split out gen_ld_atomic David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 19/35] target/ppc: Split out gen_st_atomic David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 20/35] target/ppc: Use MO_ALIGN for EXIWX and ECOWX David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 21/35] target/ppc: Use atomic min/max helpers David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 22/35] target/ppc: Implement the rest of gen_ld_atomic David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 23/35] target/ppc: Implement the rest of gen_st_atomic David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 24/35] fpu_helper.c: fix setting FPSCR[FI] bit David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 25/35] hw/ppc: Give sam46ex its own config option David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 26/35] ppc4xx_i2c: Rewrite to model hardware more closely David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 27/35] hw/timer: Add basic M41T80 emulation David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 28/35] sam460ex: Add RTC device David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 29/35] ppc440_uc: Basic emulation of PPC440 DMA controller David Gibson
2018-07-03  5:57 ` [Qemu-devel] [PULL 30/35] target/ppc/kvm: get rid of kvm_get_fallback_smmu_info() David Gibson
2018-07-03  5:58 ` [Qemu-devel] [PULL 31/35] target/ppc/kvm: don't pass cpu to kvm_get_smmu_info() David Gibson
2018-07-03  5:58 ` [Qemu-devel] [PULL 32/35] spapr: compute default value of "hpt-max-page-size" later David Gibson
2018-07-03  5:58 ` [Qemu-devel] [PULL 33/35] target/ppc: set is_jmp on ppc_tr_breakpoint_check David Gibson
2018-07-03  5:58 ` [Qemu-devel] [PULL 34/35] target/ppc: Relax reserved bitmask of indexed store instructions David Gibson
2018-07-03  5:58 ` [Qemu-devel] [PULL 35/35] ppc: Include vga cirrus card into the compiling process David Gibson
2018-07-03 19:00   ` Mark Cave-Ayland
2018-07-03 19:24     ` Sebastian Bauer
2018-07-04  4:50       ` Mark Cave-Ayland
2018-07-04  5:33         ` Sebastian Bauer
2018-07-04  5:56           ` Mark Cave-Ayland
2018-07-04  9:29             ` Sebastian Bauer
2018-07-04 10:26           ` [Qemu-devel] [Qemu-ppc] " BALATON Zoltan
2018-07-03 15:04 ` [Qemu-devel] [PULL 00/35] ppc-for-3.0 queue 20180703 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703055804.13449-4-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=clg@kaod.org \
    --cc=groug@kaod.org \
    --cc=linux@roeck-us.net \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).