From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faEjk-0007dm-IC for qemu-devel@nongnu.org; Tue, 03 Jul 2018 02:24:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faEjh-0004ya-DQ for qemu-devel@nongnu.org; Tue, 03 Jul 2018 02:24:28 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46300 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1faEjh-0004yT-6r for qemu-devel@nongnu.org; Tue, 03 Jul 2018 02:24:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CF3A487927 for ; Tue, 3 Jul 2018 06:24:24 +0000 (UTC) Date: Tue, 3 Jul 2018 14:24:19 +0800 From: Peter Xu Message-ID: <20180703062419.GS2455@xz-mi> References: <20180702162218.13678-1-armbru@redhat.com> <20180702162218.13678-8-armbru@redhat.com> <20180703033625.GP2455@xz-mi> <874lhg7sms.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <874lhg7sms.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH 07/32] qmp: Make "id" optional again even in "oob" monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, stefanha@redhat.com, dgilbert@redhat.com, Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= On Tue, Jul 03, 2018 at 08:14:35AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, Jul 02, 2018 at 06:21:53PM +0200, Markus Armbruster wrote: > >> Commit cf869d53172 "qmp: support out-of-band (oob) execution" made > >> "id" mandatory for all commands when the client accepted capability > >> "oob". This is rather onerous when you play with QMP by hand, and > >> unnecessarily so: only out-of-band commands need an ID for reliable > >> matching of response to command. > >> > >> Revert that part of commit cf869d53172 for now. We may still make > >> "id" mandatory for out-of-band commands. > > > > This change should be okay with current implementation when > > out-of-band commands are still in order themselves, though I'm still > > not that confident on whether we really want this change if only for > > the sake of easier usage for human beings. > > > > If we see Libvirt, the real player for QMP - it has the "id" field > > even for in-band commands always. I'd say the "id" field is really > > helpful for machines, though not that friendly to us. > > > > Basically I'll read it as: machines like "id"s, humans hate "id"s. > > And QMP is Qemu Machine Protocol after all... so not sure whether > > it'll be good we change that for us humans. > > "id" being optional doesn't hurt libvirt in any way. Thus, I see no > need to inconvenience humans. > > Daniel has argued[*] for making "id" mandatory with OOB commands. I'm > not rejecting that argument. But I needed to get this out in a hurry, > and simply reverting something is quicker than debating and implementing > an improvement. There's still time to tweak this before the release. > > > [*] Message-ID: <20180628120044.GF3513@redhat.com> > https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg08322.html Okay, it's fine to me then, especially if Daniel won't have other opinions. Regards, -- Peter Xu