qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, cota@braap.org, famz@redhat.com,
	berrange@redhat.com, f4bug@amsat.org,
	richard.henderson@linaro.org, balrogg@gmail.com,
	aurelien@aurel32.net, agraf@suse.de,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PULL 17/20] docker: debian-bootstrap.pre allow customising of variant/url
Date: Tue,  3 Jul 2018 11:14:41 +0100	[thread overview]
Message-ID: <20180703101444.23778-18-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180703101444.23778-1-alex.bennee@linaro.org>

We default to the buildd variant as most of our images are for
building. However lets give the user the ability to specify "minbase"
if they want to create a simple base image for experimentation.

Allowing the tweaking of DEB_URL means we can also bootstrap other
Debian based OS's. For example:

  make docker-binfmt-image-debian-ubuntu-bionic-arm64 \
       DEB_ARCH=arm64 DEB_TYPE=bionic \
       DEB_VARIANT=minbase DEB_URL=http://ports.ubuntu.com/ \
       EXECUTABLE=./aarch64-linux-user/qemu-aarch64

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre b/tests/docker/dockerfiles/debian-bootstrap.pre
index 7c76dce663..56e1aa7a21 100755
--- a/tests/docker/dockerfiles/debian-bootstrap.pre
+++ b/tests/docker/dockerfiles/debian-bootstrap.pre
@@ -32,6 +32,15 @@ if [ -z "${DEB_TYPE}" ]; then
 
 fi
 
+# The following allow finer grain control over the defaults
+if [ -z "${DEB_VARIANT}" ]; then
+    DEB_VARIANT=buildd
+fi
+
+if [ -z "${DEB_URL}" ]; then
+    DEB_URL="http://httpredir.debian.org/debian"
+fi
+
 # We check in order for
 #
 #  - DEBOOTSTRAP_DIR pointing at a development checkout
@@ -107,5 +116,5 @@ fi
 
 echo "Building a rootfs using ${FAKEROOT} and ${DEBOOTSTRAP} ${DEB_ARCH}/${DEB_TYPE}"
 
-${FAKEROOT} ${DEBOOTSTRAP} --variant=buildd --foreign --arch=$DEB_ARCH $DEB_TYPE . http://httpredir.debian.org/debian || exit 1
+${FAKEROOT} ${DEBOOTSTRAP} --variant=$DEB_VARIANT --foreign --arch=$DEB_ARCH $DEB_TYPE . $DEB_URL || exit 1
 exit 0
-- 
2.17.1

  parent reply	other threads:[~2018-07-03 10:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 10:14 [Qemu-devel] [PULL 00/20] Travis, Code Coverage and Cross Build updates Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 01/20] travis: do not waste time cloning unused submodules Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 02/20] travis: test out-of-tree builds Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 03/20] build-system: remove per-test GCOV reporting Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 04/20] .gitignore: add .gcov files Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 05/20] docker: add gcovr to travis image Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 06/20] travis: add gcovr summary for GCOV build Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 07/20] build-system: add clean-coverage target Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 08/20] build-system: add coverage-report target Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 09/20] linux-user: introduce preexit_cleanup Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 10/20] linux-user: add gcov support to preexit_cleanup Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 11/20] docker: filter out linux-user builds for mingw Alex Bennée
2018-07-03 13:44   ` Paolo Bonzini
2018-07-03 19:45     ` Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 12/20] docker: ubuntu: Update the package list before installing new ones Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 13/20] docker: ubuntu: Use SDL2 Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 14/20] docker: Clean the MXE base image Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 15/20] docker: Do not run tests in 'intermediate' images Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 16/20] docker: drop QEMU build-dep from bootstrap Alex Bennée
2018-07-03 10:14 ` Alex Bennée [this message]
2018-07-03 10:14 ` [Qemu-devel] [PULL 18/20] docker: add special handling for FROM:debian-%-user targets Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 19/20] docker: add special rule for deboostrapped images Alex Bennée
2018-07-03 10:14 ` [Qemu-devel] [PULL 20/20] docker: add linux-user powered cross builder for QEMU Alex Bennée
2018-07-03 13:46 ` [Qemu-devel] [PULL 00/20] Travis, Code Coverage and Cross Build updates Paolo Bonzini
2018-07-03 19:45   ` Alex Bennée
2018-07-04 10:15 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703101444.23778-18-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).