From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faJOG-0006zN-W3 for qemu-devel@nongnu.org; Tue, 03 Jul 2018 07:22:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faJOF-0004Ta-SF for qemu-devel@nongnu.org; Tue, 03 Jul 2018 07:22:37 -0400 Date: Tue, 3 Jul 2018 12:22:23 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180703111949.GB24516@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <7a310b92-f8cb-b68b-d882-9b2959794347@de.ibm.com> <20180622125502.GF4366@localhost.localdomain> <20180622142513.GH4366@localhost.localdomain> <20180622143146.GQ23296@redhat.com> <20180625095322.GC18580@redhat.com> <20180625114106.GJ5024@localhost.localdomain> <20180625114528.GL16514@angien.pipo.sk> <20180702080411.GA4299@localhost.localdomain> <60f6bf3c-6cad-c86f-01d7-8c376a6ccfe0@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <60f6bf3c-6cad-c86f-01d7-8c376a6ccfe0@de.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [libvirt] [PULL 25/26] block: Remove deprecated -drive option serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Kevin Wolf , Peter Krempa , Peter Maydell , Boris Fiuczynski , qemu-block@nongnu.org, libvir-list@redhat.com, qemu-devel@nongnu.org On Tue, Jul 03, 2018 at 12:53:44PM +0200, Christian Borntraeger wrote: >=20 >=20 > On 07/02/2018 10:04 AM, Kevin Wolf wrote: > > Am 25.06.2018 um 13:45 hat Peter Krempa geschrieben: > >> On Mon, Jun 25, 2018 at 13:41:06 +0200, Kevin Wolf wrote: > >>> Am 25.06.2018 um 11:53 hat Daniel P. Berrang=C3=A9 geschrieben: > >>>> On Fri, Jun 22, 2018 at 03:31:46PM +0100, Daniel P. Berrang=C3=A9 = wrote: > >>>>> On Fri, Jun 22, 2018 at 04:25:13PM +0200, Kevin Wolf wrote: > >>>>>> Am 22.06.2018 um 15:36 hat Christian Borntraeger geschrieben: > >> > >> [...] > >> > >>> > >>> Thanks! > >>> > >>> I'll look into werror/rerror support for usb-storage. It shouldn't = be > >>> too hard, though it's strictly speaking a separate problem related = to > >>> using -blockdev rather than option deprecation. > >>> > >>> If Peter wants to wait for QEMU support before converting werror/re= rror > >> > >> Definitely. I don't want to keep around yet another hack that will > >> satisfy one specific case and then add another capability for it. We > >> should then gate the moving of the feature based on the presence of > >> werror for usb-storage. > >> > >>> to -device, maybe it would make sense to split your patch for v2 so= that > >>> geometry and serial can get fixed right away? > >> > >> Yes this can be done right away. > >=20 > > Has serial/gemoetry been fixed meanwhile and will it make it into the > > next release? >=20 > I cannot find an archive that has it, but it is on the libvirt mailing > list as "[libvirt] [PATCH v3] qemu: format serial and geometry on front= end disk device". > Review seems done, but it has missed libvirt 4.5 which was released tod= ay. Just posted latest version here: https://www.redhat.com/archives/libvir-list/2018-July/msg00130.html It will be in the next release on ~ Aug 1st Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|