* [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12
@ 2018-07-03 1:10 Eduardo Habkost
2018-07-03 15:07 ` Igor Mammedov
2018-07-09 15:48 ` Moger, Babu
0 siblings, 2 replies; 3+ messages in thread
From: Eduardo Habkost @ 2018-07-03 1:10 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Paolo Bonzini, Babu Moger, Michael S. Tsirkin,
Igor Mammedov
I forgot a hyphen when amending the compat code on commit
e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU").
Fixes: e00516475c270dcb6705753da96063f95699abf2
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Bug detected by compat_checker:
https://github.com/ehabkost/gdb-qemu
---
include/hw/i386/pc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 4d99d69681..654003f44c 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
.property = "xlevel",\
.value = stringify(0x8000000a),\
},{\
- .driver = "EPYC-IBPB" TYPE_X86_CPU,\
+ .driver = "EPYC-IBPB-" TYPE_X86_CPU,\
.property = "xlevel",\
.value = stringify(0x8000000a),\
},
--
2.18.0.rc1.1.g3f1ff2140
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12
2018-07-03 1:10 [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12 Eduardo Habkost
@ 2018-07-03 15:07 ` Igor Mammedov
2018-07-09 15:48 ` Moger, Babu
1 sibling, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2018-07-03 15:07 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-devel, Paolo Bonzini, Babu Moger, Michael S. Tsirkin
On Mon, 2 Jul 2018 22:10:26 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:
> I forgot a hyphen when amending the compat code on commit
> e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU").
>
> Fixes: e00516475c270dcb6705753da96063f95699abf2
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Bug detected by compat_checker:
> https://github.com/ehabkost/gdb-qemu
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 4d99d69681..654003f44c 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> .property = "xlevel",\
> .value = stringify(0x8000000a),\
> },{\
> - .driver = "EPYC-IBPB" TYPE_X86_CPU,\
> + .driver = "EPYC-IBPB-" TYPE_X86_CPU,\
> .property = "xlevel",\
> .value = stringify(0x8000000a),\
> },
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12
2018-07-03 1:10 [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12 Eduardo Habkost
2018-07-03 15:07 ` Igor Mammedov
@ 2018-07-09 15:48 ` Moger, Babu
1 sibling, 0 replies; 3+ messages in thread
From: Moger, Babu @ 2018-07-09 15:48 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel@nongnu.org
Cc: Paolo Bonzini, Michael S. Tsirkin, Igor Mammedov
Looks good. thanks
> -----Original Message-----
> From: Eduardo Habkost [mailto:ehabkost@redhat.com]
> Sent: Monday, July 2, 2018 8:10 PM
> To: qemu-devel@nongnu.org
> Cc: Eduardo Habkost <ehabkost@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; Moger, Babu <Babu.Moger@amd.com>; Michael
> S. Tsirkin <mst@redhat.com>; Igor Mammedov <imammedo@redhat.com>
> Subject: [PATCH] pc: Fix typo on PC_COMPAT_2_12
>
> I forgot a hyphen when amending the compat code on commit
> e0051647 ("i386: Enable TOPOEXT feature on AMD EPYC CPU").
>
> Fixes: e00516475c270dcb6705753da96063f95699abf2
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Babu Moger <babu.moger@amd.com>
> ---
> Bug detected by compat_checker:
> https://github.com/ehabkost/gdb-qemu
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 4d99d69681..654003f44c 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -309,7 +309,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *,
> uint64_t *);
> .property = "xlevel",\
> .value = stringify(0x8000000a),\
> },{\
> - .driver = "EPYC-IBPB" TYPE_X86_CPU,\
> + .driver = "EPYC-IBPB-" TYPE_X86_CPU,\
> .property = "xlevel",\
> .value = stringify(0x8000000a),\
> },
> --
> 2.18.0.rc1.1.g3f1ff2140
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-09 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 1:10 [Qemu-devel] [PATCH] pc: Fix typo on PC_COMPAT_2_12 Eduardo Habkost
2018-07-03 15:07 ` Igor Mammedov
2018-07-09 15:48 ` Moger, Babu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).