qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Chen Hanxiao" <chenhanxiao@gmail.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [Qemu-devel] [PULL 03/14] qga: add mountpoint usage info to GuestFilesystemInfo
Date: Tue,  3 Jul 2018 15:52:10 -0500	[thread overview]
Message-ID: <20180703205221.24788-4-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180703205221.24788-1-mdroth@linux.vnet.ibm.com>

From: Chen Hanxiao <chenhanxiao@gmail.com>

This patch adds support for getting the usage of mounted
filesystem.
The usage of fs stored as used_bytes and total_bytes.
It's very useful when we try to monitor guest's filesystem.

Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qga/commands-posix.c | 15 +++++++++++++++
 qga/qapi-schema.json |  3 +++
 2 files changed, 18 insertions(+)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 9284e71666..ae8535e497 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -46,6 +46,7 @@ extern char **environ;
 #include <arpa/inet.h>
 #include <sys/socket.h>
 #include <net/if.h>
+#include <sys/statvfs.h>
 
 #ifdef FIFREEZE
 #define CONFIG_FSFREEZE
@@ -1072,6 +1073,8 @@ static GuestFilesystemInfo *build_guest_fsinfo(struct FsMount *mount,
                                                Error **errp)
 {
     GuestFilesystemInfo *fs = g_malloc0(sizeof(*fs));
+    struct statvfs buf;
+    unsigned long used, nonroot_total, fr_size;
     char *devpath = g_strdup_printf("/sys/dev/block/%u:%u",
                                     mount->devmajor, mount->devminor);
 
@@ -1079,7 +1082,19 @@ static GuestFilesystemInfo *build_guest_fsinfo(struct FsMount *mount,
     fs->type = g_strdup(mount->devtype);
     build_guest_fsinfo_for_device(devpath, fs, errp);
 
+    if (statvfs(fs->mountpoint, &buf) == 0) {
+        fr_size = buf.f_frsize;
+        used = buf.f_blocks - buf.f_bfree;
+        nonroot_total = used + buf.f_bavail;
+        fs->used_bytes = used * fr_size;
+        fs->total_bytes = nonroot_total * fr_size;
+
+        fs->has_total_bytes = true;
+        fs->has_used_bytes = true;
+    }
+
     g_free(devpath);
+
     return fs;
 }
 
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 1045cef386..2df6356b8c 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -848,6 +848,8 @@
 # @name: disk name
 # @mountpoint: mount point path
 # @type: file system type string
+# @used-bytes: file system used bytes (since 3.0)
+# @total-bytes: non-root file system total bytes (since 3.0)
 # @disk: an array of disk hardware information that the volume lies on,
 #        which may be empty if the disk type is not supported
 #
@@ -855,6 +857,7 @@
 ##
 { 'struct': 'GuestFilesystemInfo',
   'data': {'name': 'str', 'mountpoint': 'str', 'type': 'str',
+           '*used-bytes': 'uint64', '*total-bytes': 'uint64',
            'disk': ['GuestDiskAddress']} }
 
 ##
-- 
2.11.0

  parent reply	other threads:[~2018-07-03 20:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 20:52 [Qemu-devel] [PULL 00/14] qga patch queue for soft-freeze Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 01/14] qga: unset frozen state if no mount points are frozen Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 02/14] qga: check bytes count read by guest-file-read Michael Roth
2018-07-03 20:52 ` Michael Roth [this message]
2018-07-03 20:52 ` [Qemu-devel] [PULL 04/14] qga-win: add driver path usage to GuestFilesystemInfo Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 05/14] test-qga: add trivial tests for some commands Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 06/14] qga/schema: fix documentation for GuestOSInfo Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 07/14] qga-win: Fixing msi upgrade disallow in WiX file Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 08/14] qemu-ga: make get-fsinfo work over pci bridges Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 09/14] qga: refactoring qmp_guest_suspend_* functions Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 10/14] qga: bios_supports_mode: decoupling pm-utils and sys logic Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 11/14] qga: guest_suspend: " Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 12/14] qga: removing switch statements, adding run_process_child Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 13/14] qga: systemd hibernate/suspend/hybrid-sleep support Michael Roth
2018-07-03 20:52 ` [Qemu-devel] [PULL 14/14] qga: removing bios_supports_mode Michael Roth
2018-07-05  9:31 ` [Qemu-devel] [PULL 00/14] qga patch queue for soft-freeze Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703205221.24788-4-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=berrange@redhat.com \
    --cc=chenhanxiao@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).