* [Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event
@ 2018-07-04 12:04 Paolo Bonzini
2018-07-04 14:35 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2018-07-04 12:04 UTC (permalink / raw)
To: qemu-devel
Reported by Coverity.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
scsi/pr-manager-helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c
index 519a296905..3027dde60d 100644
--- a/scsi/pr-manager-helper.c
+++ b/scsi/pr-manager-helper.c
@@ -46,6 +46,7 @@ static void pr_manager_send_status_changed_event(PRManagerHelper *pr_mgr)
if (id) {
qapi_event_send_pr_manager_status_changed(id, !!pr_mgr->ioc,
&error_abort);
+ g_free(id);
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event
2018-07-04 12:04 [Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event Paolo Bonzini
@ 2018-07-04 14:35 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-07-04 14:35 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 07/04/2018 09:04 AM, Paolo Bonzini wrote:
> Reported by Coverity.
>
Fixes: Coverity CID 1393785 (Resource leak)
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> scsi/pr-manager-helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c
> index 519a296905..3027dde60d 100644
> --- a/scsi/pr-manager-helper.c
> +++ b/scsi/pr-manager-helper.c
> @@ -46,6 +46,7 @@ static void pr_manager_send_status_changed_event(PRManagerHelper *pr_mgr)
> if (id) {
> qapi_event_send_pr_manager_status_changed(id, !!pr_mgr->ioc,
> &error_abort);
> + g_free(id);
> }
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-04 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-04 12:04 [Qemu-devel] [PATCH] pr-manager-helper: fix memory leak on event Paolo Bonzini
2018-07-04 14:35 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).