* [Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error
@ 2018-07-04 14:44 Philippe Mathieu-Daudé
2018-07-04 16:40 ` BALATON Zoltan
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-07-04 14:44 UTC (permalink / raw)
To: BALATON Zoltan, David Gibson, Alexander Graf
Cc: Philippe Mathieu-Daudé, qemu-devel, Paolo Bonzini, qemu-ppc
Missed in 3c409c1927e, hopefully reported by Coverity.
Fixes: Coverity CID 1393788 (Copy-paste error)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/ppc/ppc440_uc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
index 0bbaa6844a..09ccda548f 100644
--- a/hw/ppc/ppc440_uc.c
+++ b/hw/ppc/ppc440_uc.c
@@ -935,7 +935,7 @@ static void dcr_write_dma(void *opaque, int dcrn, uint32_t val)
if (wptr) {
cpu_physical_memory_unmap(wptr, wlen, 1, didx);
}
- if (wptr) {
+ if (rptr) {
cpu_physical_memory_unmap(rptr, rlen, 0, sidx);
}
}
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error
2018-07-04 14:44 [Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error Philippe Mathieu-Daudé
@ 2018-07-04 16:40 ` BALATON Zoltan
2018-07-05 0:13 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: BALATON Zoltan @ 2018-07-04 16:40 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: David Gibson, Alexander Graf, qemu-devel, Paolo Bonzini, qemu-ppc
On Wed, 4 Jul 2018, Philippe Mathieu-Daudé wrote:
> Missed in 3c409c1927e, hopefully reported by Coverity.
Apparently Coverity did report it and Paolo already notified me about
that. I was about to send a patch but you were faster. Thank you very
much.
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
> Fixes: Coverity CID 1393788 (Copy-paste error)
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/ppc/ppc440_uc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> index 0bbaa6844a..09ccda548f 100644
> --- a/hw/ppc/ppc440_uc.c
> +++ b/hw/ppc/ppc440_uc.c
> @@ -935,7 +935,7 @@ static void dcr_write_dma(void *opaque, int dcrn, uint32_t val)
> if (wptr) {
> cpu_physical_memory_unmap(wptr, wlen, 1, didx);
> }
> - if (wptr) {
> + if (rptr) {
> cpu_physical_memory_unmap(rptr, rlen, 0, sidx);
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error
2018-07-04 16:40 ` BALATON Zoltan
@ 2018-07-05 0:13 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2018-07-05 0:13 UTC (permalink / raw)
To: BALATON Zoltan
Cc: Philippe Mathieu-Daudé, Alexander Graf, qemu-devel,
Paolo Bonzini, qemu-ppc
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
On Wed, Jul 04, 2018 at 06:40:35PM +0200, BALATON Zoltan wrote:
> On Wed, 4 Jul 2018, Philippe Mathieu-Daudé wrote:
> > Missed in 3c409c1927e, hopefully reported by Coverity.
>
> Apparently Coverity did report it and Paolo already notified me about that.
> I was about to send a patch but you were faster. Thank you very much.
>
> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Applied to ppc-for-3.0, thanks.
>
> > Fixes: Coverity CID 1393788 (Copy-paste error)
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > hw/ppc/ppc440_uc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/ppc440_uc.c b/hw/ppc/ppc440_uc.c
> > index 0bbaa6844a..09ccda548f 100644
> > --- a/hw/ppc/ppc440_uc.c
> > +++ b/hw/ppc/ppc440_uc.c
> > @@ -935,7 +935,7 @@ static void dcr_write_dma(void *opaque, int dcrn, uint32_t val)
> > if (wptr) {
> > cpu_physical_memory_unmap(wptr, wlen, 1, didx);
> > }
> > - if (wptr) {
> > + if (rptr) {
> > cpu_physical_memory_unmap(rptr, rlen, 0, sidx);
> > }
> > }
> >
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-05 0:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-04 14:44 [Qemu-devel] [PATCH] ppc440_uc: Fix a copy/paste error Philippe Mathieu-Daudé
2018-07-04 16:40 ` BALATON Zoltan
2018-07-05 0:13 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).