qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	peterx@redhat.com
Subject: [Qemu-devel] [PATCH for-3.0 9/9] tests: hide stderr for postcopy recovery test
Date: Thu,  5 Jul 2018 11:17:55 +0800	[thread overview]
Message-ID: <20180705031755.3254-10-peterx@redhat.com> (raw)
In-Reply-To: <20180705031755.3254-1-peterx@redhat.com>

We dumped something when network failure happens.  We should avoid those
messages to be dumped when running the tests:

  $ ./tests/migration-test -p /x86_64/migration/postcopy/recovery
  /x86_64/migration/postcopy/recovery: qemu-system-x86_64: check_section_footer: Read section footer failed: -5
  qemu-system-x86_64: Detected IO failure for postcopy. Migration paused.
  qemu-system-x86_64: Detected IO failure for postcopy. Migration paused.
  OK

After the patch:

  $ ./tests/migration-test -p /x86_64/migration/postcopy/recovery
  /x86_64/migration/postcopy/recovery: OK

Signed-off-by: Peter Xu <peterx@redhat.com>
---
 tests/migration-test.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index 182fc88e93..96e69dab99 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -567,12 +567,13 @@ static void test_deprecated(void)
 }
 
 static void migrate_postcopy_prepare(QTestState **from_ptr,
-                                     QTestState **to_ptr)
+                                     QTestState **to_ptr,
+                                     bool hide_error)
 {
     char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
     QTestState *from, *to;
 
-    test_migrate_start(&from, &to, uri, false);
+    test_migrate_start(&from, &to, uri, hide_error);
 
     migrate_set_capability(from, "postcopy-ram", "true");
     migrate_set_capability(to, "postcopy-ram", "true");
@@ -615,7 +616,7 @@ static void test_postcopy(void)
 {
     QTestState *from, *to;
 
-    migrate_postcopy_prepare(&from, &to);
+    migrate_postcopy_prepare(&from, &to, false);
     migrate_postcopy_start(from, to);
     migrate_postcopy_complete(from, to);
 }
@@ -625,7 +626,7 @@ static void test_postcopy_recovery(void)
     QTestState *from, *to;
     char *uri;
 
-    migrate_postcopy_prepare(&from, &to);
+    migrate_postcopy_prepare(&from, &to, true);
 
     /* Turn postcopy speed down, 4K/s is slow enough on any machines */
     migrate_set_parameter(from, "max-postcopy-bandwidth", "4096");
-- 
2.17.1

  parent reply	other threads:[~2018-07-05  3:18 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  3:17 [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes Peter Xu
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 1/9] migration: simplify check to use qemu file buffer Peter Xu
2018-07-05  9:01   ` Dr. David Alan Gilbert
2018-07-05  9:11     ` Peter Xu
2018-07-05 12:59   ` Juan Quintela
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 2/9] migration: loosen recovery check when load vm Peter Xu
2018-07-05  9:15   ` Dr. David Alan Gilbert
2018-07-05  9:31     ` Peter Xu
2018-07-05 13:01   ` Juan Quintela
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 3/9] migration: fix incorrect bitmap size calculation Peter Xu
2018-07-05  9:38   ` Dr. David Alan Gilbert
2018-07-05 13:01   ` Juan Quintela
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 4/9] tests: introduce migrate_postcopy_* helpers Peter Xu
2018-07-05  9:31   ` Balamuruhan S
2018-07-06  2:19     ` Peter Xu
2018-07-06  6:17       ` Balamuruhan S
2018-07-05  9:59   ` Dr. David Alan Gilbert
2018-07-05 13:03   ` Juan Quintela
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 5/9] tests: allow migrate() to take extra flags Peter Xu
2018-07-05 10:18   ` Dr. David Alan Gilbert
2018-07-05 13:05   ` Juan Quintela
2018-07-06 10:36   ` Balamuruhan S
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 6/9] tests: introduce migrate_query*() helpers Peter Xu
2018-07-05 10:23   ` Dr. David Alan Gilbert
2018-07-05 13:07     ` Juan Quintela
2018-07-05 10:59   ` Balamuruhan S
2018-07-05 13:06   ` Juan Quintela
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 7/9] tests: introduce wait_for_migration_status() Peter Xu
2018-07-05 10:27   ` Dr. David Alan Gilbert
2018-07-05 13:07   ` Juan Quintela
2018-07-06 10:41   ` Balamuruhan S
2018-07-05  3:17 ` [Qemu-devel] [PATCH for-3.0 8/9] tests: add postcopy recovery test Peter Xu
2018-07-05 10:30   ` Dr. David Alan Gilbert
2018-07-05 13:08   ` Juan Quintela
2018-07-05  3:17 ` Peter Xu [this message]
2018-07-05 10:36   ` [Qemu-devel] [PATCH for-3.0 9/9] tests: hide stderr for " Dr. David Alan Gilbert
2018-07-05 13:09   ` Juan Quintela
2018-07-06  9:17 ` [Qemu-devel] [PATCH for-3.0 0/9] migration: postcopy recovery unit test, bug fixes Dr. David Alan Gilbert
2018-07-06 10:56   ` Dr. David Alan Gilbert
2018-07-06 11:45     ` Balamuruhan S
2018-07-06 12:46     ` Balamuruhan S
2018-07-12  8:50       ` Dr. David Alan Gilbert
2018-07-10  3:27     ` Peter Xu
2018-07-10  8:53       ` Dr. David Alan Gilbert
2018-07-10  1:56 ` Balamuruhan S
2018-07-10  3:07   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705031755.3254-10-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).