From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Alexander Graf <agraf@suse.de>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Aleksandar Markovic <aleksandar.markovic@mips.com>,
Aurelien Jarno <aurelien@aurel32.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
BALATON Zoltan <balaton@eik.bme.hu>,
qemu-ppc@nongnu.org, Richard Henderson <rth@twiddle.net>,
Sebastian Bauer <mail@sebastianbauer.info>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/2] vga: set default_display for all machines using cirrus.
Date: Thu, 5 Jul 2018 08:43:47 +0200 [thread overview]
Message-ID: <20180705064348.3162-2-kraxel@redhat.com> (raw)
In-Reply-To: <20180705064348.3162-1-kraxel@redhat.com>
Explicitly set MachineClass->default_display to "cirrus" for all machine
types (alpha, mips, old i386 versions) which use cirrus today, so they
don't depend on cirrus being the default display device.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/alpha/dp264.c | 1 +
hw/i386/pc_piix.c | 2 +-
hw/mips/mips_malta.c | 1 +
hw/mips/mips_r4k.c | 1 +
4 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
index 80b987f7fb..668e6d099f 100644
--- a/hw/alpha/dp264.c
+++ b/hw/alpha/dp264.c
@@ -182,6 +182,7 @@ static void clipper_machine_init(MachineClass *mc)
mc->max_cpus = 4;
mc->is_default = 1;
mc->default_cpu_type = ALPHA_CPU_TYPE_NAME("ev67");
+ mc->default_display = "cirrus";
}
DEFINE_MACHINE("clipper", clipper_machine_init)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index dc09466b3e..bcf866ee34 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -566,7 +566,7 @@ static void pc_i440fx_2_1_machine_options(MachineClass *m)
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
pc_i440fx_2_2_machine_options(m);
m->hw_version = "2.1.0";
- m->default_display = NULL;
+ m->default_display = "cirrus";
SET_MACHINE_COMPAT(m, PC_COMPAT_2_1);
pcmc->smbios_uuid_encoded = false;
pcmc->enforce_aligned_dimm = false;
diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
index 3467451482..998971c53a 100644
--- a/hw/mips/mips_malta.c
+++ b/hw/mips/mips_malta.c
@@ -1242,6 +1242,7 @@ static void mips_malta_machine_init(MachineClass *mc)
mc->block_default_type = IF_IDE;
mc->max_cpus = 16;
mc->is_default = 1;
+ mc->default_display = "cirrus";
#ifdef TARGET_MIPS64
mc->default_cpu_type = MIPS_CPU_TYPE_NAME("20Kc");
#else
diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
index d5725d0555..c4c7ee8aa5 100644
--- a/hw/mips/mips_r4k.c
+++ b/hw/mips/mips_r4k.c
@@ -295,6 +295,7 @@ static void mips_machine_init(MachineClass *mc)
mc->desc = "mips r4k platform";
mc->init = mips_r4k_init;
mc->block_default_type = IF_IDE;
+ mc->default_display = "cirrus";
#ifdef TARGET_MIPS64
mc->default_cpu_type = MIPS_CPU_TYPE_NAME("R4000");
#else
--
2.9.3
next prev parent reply other threads:[~2018-07-05 6:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 6:43 [Qemu-devel] [PATCH v2 0/2] vga: make stdvga the global default Gerd Hoffmann
2018-07-05 6:43 ` Gerd Hoffmann [this message]
2018-07-05 16:35 ` [Qemu-devel] [PATCH v2 1/2] vga: set default_display for all machines using cirrus Eduardo Habkost
2018-07-05 6:43 ` [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default Gerd Hoffmann
2018-07-05 16:35 ` Eduardo Habkost
2018-07-06 6:53 ` Gerd Hoffmann
2018-07-09 21:08 ` Eduardo Habkost
2018-07-09 21:23 ` Eduardo Habkost
2018-07-09 22:26 ` Sebastian Bauer
2018-07-11 15:48 ` Eduardo Habkost
2018-07-11 17:00 ` Sebastian Bauer
2018-07-11 18:43 ` Eduardo Habkost
2018-07-12 4:57 ` [Qemu-devel] [Qemu-ppc] " Thomas Huth
2018-07-12 7:37 ` Sebastian Bauer
2018-07-12 17:27 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705064348.3162-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=aleksandar.markovic@mips.com \
--cc=aurelien@aurel32.net \
--cc=balaton@eik.bme.hu \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=mail@sebastianbauer.info \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).