Re: [Qemu-devel] [PATCH] block/crypto: Simplify block_crypto_co_create_opts_luks to avoid a memory leak

[Kevin Wolf <kwolf@redhat.com>]

Am 04.07.2018 um 17:02 hat Philippe Mathieu-Daudé geschrieben:
> After 1ec4f4160a1 Coverity reported:
> 
>   Variable cryptoopts going out of scope leaks the storage it points to.
> 
> Fixes: Coverity CID 1393782 (Resource leak)
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

I already sent a much simpler fix:
[PATCH] block/crypto: Fix memory leak in create error path

The only thing that is needed is replacing the return with a goto.
Splitting it in three different error paths is unnecessary because the
cleanup function handle NULL values just fine.

> I think this check is superfluous but I respected the previous code:
> 
>      ret = block_crypto_co_create_generic(bs, size, create_opts, errp);
>      if (ret > 0) {
>          ret = 0;
>      }

It is wrong, too. The old code keep the error code, goto fail skipped
the ret = 0.

Kevin