From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb1XT-0002Xo-Js for qemu-devel@nongnu.org; Thu, 05 Jul 2018 06:31:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fb1XO-0000Kx-N9 for qemu-devel@nongnu.org; Thu, 05 Jul 2018 06:31:03 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57872 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fb1XO-0000JY-H6 for qemu-devel@nongnu.org; Thu, 05 Jul 2018 06:30:58 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BF3981A4EAA for ; Thu, 5 Jul 2018 10:30:58 +0000 (UTC) Date: Thu, 5 Jul 2018 11:30:52 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180705103052.GJ2538@work-vm> References: <20180705031755.3254-1-peterx@redhat.com> <20180705031755.3254-9-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180705031755.3254-9-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-3.0 8/9] tests: add postcopy recovery test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Juan Quintela * Peter Xu (peterx@redhat.com) wrote: > Test the postcopy recovery procedure by emulating a network failure > using migrate-pause command. > > Signed-off-by: Peter Xu OK, that's nice. Reviewed-by: Dr. David Alan Gilbert > --- > tests/migration-test.c | 71 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/tests/migration-test.c b/tests/migration-test.c > index 761bf62ffe..182fc88e93 100644 > --- a/tests/migration-test.c > +++ b/tests/migration-test.c > @@ -352,6 +352,29 @@ static void migrate_set_parameter(QTestState *who, const char *parameter, > migrate_check_parameter(who, parameter, value); > } > > +static void migrate_pause(QTestState *who) > +{ > + QDict *rsp; > + > + rsp = wait_command(who, "{ 'execute': 'migrate-pause' }"); > + g_assert(qdict_haskey(rsp, "return")); > + qobject_unref(rsp); > +} > + > +static void migrate_recover(QTestState *who, const char *uri) > +{ > + QDict *rsp; > + gchar *cmd = g_strdup_printf( > + "{ 'execute': 'migrate-recover', " > + " 'id': 'recover-cmd', " > + " 'arguments': { 'uri': '%s' } }", uri); > + > + rsp = wait_command(who, cmd); > + g_assert(qdict_haskey(rsp, "return")); > + g_free(cmd); > + qobject_unref(rsp); > +} > + > static void migrate_set_capability(QTestState *who, const char *capability, > const char *value) > { > @@ -597,6 +620,53 @@ static void test_postcopy(void) > migrate_postcopy_complete(from, to); > } > > +static void test_postcopy_recovery(void) > +{ > + QTestState *from, *to; > + char *uri; > + > + migrate_postcopy_prepare(&from, &to); > + > + /* Turn postcopy speed down, 4K/s is slow enough on any machines */ > + migrate_set_parameter(from, "max-postcopy-bandwidth", "4096"); > + > + /* Now we start the postcopy */ > + migrate_postcopy_start(from, to); > + > + /* > + * Wait until postcopy is really started; we can only run the > + * migrate-pause command during a postcopy > + */ > + wait_for_migration_status(from, "postcopy-active"); > + > + /* > + * Manually stop the postcopy migration. This emulates a network > + * failure with the migration socket > + */ > + migrate_pause(from); > + > + /* > + * Create a new socket to emulate a new channel that is different > + * from the broken migration channel; tell the destination to > + * listen to the new port > + */ > + uri = g_strdup_printf("unix:%s/migsocket-recover", tmpfs); > + migrate_recover(to, uri); > + > + /* > + * Try to rebuild the migration channel using the resume flag and > + * the newly created channel > + */ > + wait_for_migration_status(from, "postcopy-paused"); > + migrate(from, uri, ", 'resume': true"); > + g_free(uri); > + > + /* Restore the postcopy bandwidth to unlimited */ > + migrate_set_parameter(from, "max-postcopy-bandwidth", "0"); > + > + migrate_postcopy_complete(from, to); > +} > + > static void test_baddest(void) > { > QTestState *from, *to; > @@ -683,6 +753,7 @@ int main(int argc, char **argv) > module_call_init(MODULE_INIT_QOM); > > qtest_add_func("/migration/postcopy/unix", test_postcopy); > + qtest_add_func("/migration/postcopy/recovery", test_postcopy_recovery); > qtest_add_func("/migration/deprecated", test_deprecated); > qtest_add_func("/migration/bad_dest", test_baddest); > qtest_add_func("/migration/precopy/unix", test_precopy_unix); > -- > 2.17.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK