From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fb45X-0004f6-0M for qemu-devel@nongnu.org; Thu, 05 Jul 2018 09:14:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fb45T-0004bS-0y for qemu-devel@nongnu.org; Thu, 05 Jul 2018 09:14:22 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35802 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fb45S-0004a9-Sg for qemu-devel@nongnu.org; Thu, 05 Jul 2018 09:14:18 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6DFC67262D for ; Thu, 5 Jul 2018 13:14:18 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A9FB7C3F for ; Thu, 5 Jul 2018 13:14:18 +0000 (UTC) From: Markus Armbruster Date: Thu, 5 Jul 2018 15:14:17 +0200 Message-Id: <20180705131417.1847-2-armbru@redhat.com> In-Reply-To: <20180705131417.1847-1-armbru@redhat.com> References: <20180705131417.1847-1-armbru@redhat.com> Subject: [Qemu-devel] [PULL 1/1] coverity-model: Fix replay_get_byte() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Coverity 2018.06 chokes on replay_get_byte(): $ cov-make-library -of scripts/coverity-model.xmldb scripts/coverity-model.c output file: scripts/coverity-model.xmldb Compiling scripts/coverity-model.c with command /opt/cov-sa-2018.06/bin/cov-emit --dir /tmp/cov-armbru/930a6fb31e5f464fc1a53354b2deb66b/cov-make-library-emit -w --no_error_recovery --emit_header_functions --no_implicit_decl --preinclude /opt/cov-sa-2018.06/library/decls.h --c scripts/coverity-model.c "scripts/coverity-model.c", line 110: error #20: identifier "replay_file" is undefined if (replay_file) { ^ Emit for file '/work/armbru/qemu/scripts/coverity-model.c' complete. [ERROR] 1 error detected in the compilation of "scripts/coverity-model.c". ERROR: cov-emit returned with code 1 Broken in commit 04a0afe5285. Fix by dumbing down. Signed-off-by: Markus Armbruster Message-Id: <20180626085642.4973-1-armbru@redhat.com> Reviewed-by: Paolo Bonzini --- scripts/coverity-model.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c index 48b112393b..2c0346ff25 100644 --- a/scripts/coverity-model.c +++ b/scripts/coverity-model.c @@ -106,12 +106,8 @@ static int get_keysym(const name2keysym_t *table, /* Replay data is considered trusted. */ uint8_t replay_get_byte(void) { - uint8_t byte = 0; - if (replay_file) { - uint8_t c; - byte = c; - } - return byte; + uint8_t byte; + return byte; } -- 2.17.1