From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-trivial@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>
Subject: [Qemu-devel] [PATCH v2 3/7] xen: Use the PCI_DEVICE macro
Date: Thu, 5 Jul 2018 12:58:07 -0300 [thread overview]
Message-ID: <20180705155811.20366-4-f4bug@amsat.org> (raw)
In-Reply-To: <20180705155811.20366-1-f4bug@amsat.org>
TYPE_XEN_PT_DEVICE is a subclass of TYPE_PCI_DEVICE, the clean way
to access the PCIDevice pointer is using the PCI_DEVICE() macro.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/xen/xen_pt_config_init.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index aee31c62bb..47f9010c75 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -358,7 +358,7 @@ static uint64_t xen_pt_get_bar_size(PCIIORegion *r)
static XenPTBarFlag xen_pt_bar_reg_parse(XenPCIPassthroughState *s,
int index)
{
- PCIDevice *d = &s->dev;
+ PCIDevice *d = PCI_DEVICE(s);
XenPTRegion *region = NULL;
PCIIORegion *r;
@@ -469,7 +469,7 @@ static int xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry,
{
XenPTRegInfo *reg = cfg_entry->reg;
XenPTRegion *base = NULL;
- PCIDevice *d = &s->dev;
+ PCIDevice *d = PCI_DEVICE(s);
const PCIIORegion *r;
uint32_t writable_mask = 0;
uint32_t bar_emu_mask = 0;
@@ -543,7 +543,7 @@ static int xen_pt_exp_rom_bar_reg_write(XenPCIPassthroughState *s,
{
XenPTRegInfo *reg = cfg_entry->reg;
XenPTRegion *base = NULL;
- PCIDevice *d = (PCIDevice *)&s->dev;
+ PCIDevice *d = PCI_DEVICE(s);
uint32_t writable_mask = 0;
uint32_t throughable_mask = get_throughable_mask(s, reg, valid_mask);
pcibus_t r_size = 0;
@@ -1587,7 +1587,7 @@ static int xen_pt_pcie_size_init(XenPCIPassthroughState *s,
const XenPTRegGroupInfo *grp_reg,
uint32_t base_offset, uint8_t *size)
{
- PCIDevice *d = &s->dev;
+ PCIDevice *d = PCI_DEVICE(s);
uint8_t version = get_capability_version(s, base_offset);
uint8_t type = get_device_type(s, base_offset);
uint8_t pcie_size = 0;
--
2.18.0
next prev parent reply other threads:[~2018-07-05 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 15:58 [Qemu-devel] [PATCH v2 0/7] Coccinelle cleanups Philippe Mathieu-Daudé
2018-07-05 15:58 ` [Qemu-devel] [PATCH v2 1/7] qobject: Catch another straggler for use of qdict_put_str() Philippe Mathieu-Daudé
2018-07-05 15:58 ` [Qemu-devel] [PATCH v2 2/7] error: Remove NULL checks on error_propagate() calls Philippe Mathieu-Daudé
2018-07-05 16:14 ` Cornelia Huck
2018-07-05 15:58 ` Philippe Mathieu-Daudé [this message]
2018-07-05 15:58 ` [Qemu-devel] [PATCH v2 4/7] tests/bios-tables-test: Remove an useless cast Philippe Mathieu-Daudé
2018-07-05 16:13 ` Eric Blake
2018-07-05 16:17 ` Philippe Mathieu-Daudé
2018-07-05 15:58 ` [Qemu-devel] [PATCH v2 5/7] ui/vnc: Remove useless parenthesis around DIV_ROUND_UP macro Philippe Mathieu-Daudé
2018-07-05 15:58 ` [Qemu-devel] [PATCH v2 6/7] hw/pci-host: " Philippe Mathieu-Daudé
2018-07-05 15:58 ` [Qemu-devel] [PATCH v2 7/7] hw/intc/gicv3: " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705155811.20366-4-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=anthony.perard@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).