Re: [Qemu-devel] [PATCH v2 2/2] vga: don't pick cirrus by default

[Eduardo Habkost <ehabkost@redhat.com>]

On Thu, Jul 05, 2018 at 08:43:48AM +0200, Gerd Hoffmann wrote:
> Now that all machines which need cirrus explicitly select it qemu
> doesn't need to consider it as default display any more.  Drop it.
> 
> With this patch applied all ppc machine types will use "std" as default
> display, no matter whenever cirrus-vga is compiled in or not.
> 
> Fixes: 29f9cef39e ppc: Include vga cirrus card into the compiling process
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Do we have a list of all machine-types with default_display==NULL
that would be affected by this?  For reference, this will affect
the machines in the following binaries:

default-configs/alpha-softmmu.mak:CONFIG_VGA_CIRRUS=y
default-configs/i386-softmmu.mak:CONFIG_VGA_CIRRUS=y
default-configs/mips-softmmu-common.mak:CONFIG_VGA_CIRRUS=y
default-configs/ppc-softmmu.mak:CONFIG_VGA_CIRRUS=y
default-configs/x86_64-softmmu.mak:CONFIG_VGA_CIRRUS=y


> ---
>  vl.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index 16b913f9d5..117e4e6879 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4475,8 +4475,6 @@ int main(int argc, char **argv, char **envp)
>      if (default_vga) {
>          if (machine_class->default_display) {
>              vga_model = machine_class->default_display;
> -        } else if (vga_interface_available(VGA_CIRRUS)) {
> -            vga_model = "cirrus";
>          } else if (vga_interface_available(VGA_STD)) {
>              vga_model = "std";
>          }
> -- 
> 2.9.3
> 

-- 
Eduardo