From: Michael Davidsaver <mdavidsaver@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Antoine Mathys <barsamin@gmail.com>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-devel@nongnu.org, Michael Davidsaver <mdavidsaver@gmail.com>
Subject: [Qemu-devel] [PATCH 08/14] timer: rename ds1338 -> dsrtc
Date: Thu, 5 Jul 2018 11:19:55 -0700 [thread overview]
Message-ID: <20180705182001.16537-9-mdavidsaver@gmail.com> (raw)
In-Reply-To: <20180705182001.16537-1-mdavidsaver@gmail.com>
Prepare to generalize with a more generic
name.
Keep device name and vmstate name "ds1338"
for compatibility.
Signed-off-by: Michael Davidsaver <mdavidsaver@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/timer/ds1338.c | 72 +++++++++++++++++++++++++++----------------------------
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c
index 0134ffd72a..3c5781d53c 100644
--- a/hw/timer/ds1338.c
+++ b/hw/timer/ds1338.c
@@ -23,8 +23,8 @@
#define CTRL_OSF 0x20
-#define TYPE_DS1338 "ds1338"
-#define DS1338(obj) OBJECT_CHECK(DS1338State, (obj), TYPE_DS1338)
+#define TYPE_DSRTC "ds1338"
+#define DSRTC(obj) OBJECT_CHECK(DSRTCState, (obj), TYPE_DSRTC)
/* values stored in BCD */
/* 00-59 */
@@ -57,7 +57,7 @@ FIELD(MONTH, CENTURY, 7, 1)
FIELD(CTRL, OSF, 5, 1)
-typedef struct DS1338State {
+typedef struct DSRTCState {
I2CSlave parent_obj;
int64_t offset;
@@ -65,24 +65,24 @@ typedef struct DS1338State {
uint8_t nvram[NVRAM_SIZE];
int32_t ptr;
bool addr_byte;
-} DS1338State;
+} DSRTCState;
-static const VMStateDescription vmstate_ds1338 = {
+static const VMStateDescription vmstate_dsrtc = {
.name = "ds1338",
.version_id = 2,
.minimum_version_id = 1,
.fields = (VMStateField[]) {
- VMSTATE_I2C_SLAVE(parent_obj, DS1338State),
- VMSTATE_INT64(offset, DS1338State),
- VMSTATE_UINT8_V(wday_offset, DS1338State, 2),
- VMSTATE_UINT8_ARRAY(nvram, DS1338State, NVRAM_SIZE),
- VMSTATE_INT32(ptr, DS1338State),
- VMSTATE_BOOL(addr_byte, DS1338State),
+ VMSTATE_I2C_SLAVE(parent_obj, DSRTCState),
+ VMSTATE_INT64(offset, DSRTCState),
+ VMSTATE_UINT8_V(wday_offset, DSRTCState, 2),
+ VMSTATE_UINT8_ARRAY(nvram, DSRTCState, NVRAM_SIZE),
+ VMSTATE_INT32(ptr, DSRTCState),
+ VMSTATE_BOOL(addr_byte, DSRTCState),
VMSTATE_END_OF_LIST()
}
};
-static void capture_current_time(DS1338State *s)
+static void capture_current_time(DSRTCState *s)
{
/* Capture the current time into the secondary registers
* which will be actually read by the data transfer operation.
@@ -119,7 +119,7 @@ static void capture_current_time(DS1338State *s)
s->nvram[R_YEAR] = to_bcd(now.tm_year - 100);
}
-static void inc_regptr(DS1338State *s)
+static void inc_regptr(DSRTCState *s)
{
/* The register pointer wraps around after 0x3F; wraparound
* causes the current time/date to be retransferred into
@@ -131,9 +131,9 @@ static void inc_regptr(DS1338State *s)
}
}
-static int ds1338_event(I2CSlave *i2c, enum i2c_event event)
+static int dsrtc_event(I2CSlave *i2c, enum i2c_event event)
{
- DS1338State *s = DS1338(i2c);
+ DSRTCState *s = DSRTC(i2c);
switch (event) {
case I2C_START_RECV:
@@ -154,9 +154,9 @@ static int ds1338_event(I2CSlave *i2c, enum i2c_event event)
return 0;
}
-static int ds1338_recv(I2CSlave *i2c)
+static int dsrtc_recv(I2CSlave *i2c)
{
- DS1338State *s = DS1338(i2c);
+ DSRTCState *s = DSRTC(i2c);
uint8_t res;
res = s->nvram[s->ptr];
@@ -167,7 +167,7 @@ static int ds1338_recv(I2CSlave *i2c)
/* call after guest writes to current time registers
* to re-compute our offset from host time.
*/
-static void ds1338_update(DS1338State *s)
+static void dsrtc_update(DSRTCState *s)
{
struct tm now = {};
@@ -204,9 +204,9 @@ static void ds1338_update(DS1338State *s)
}
}
-static int ds1338_send(I2CSlave *i2c, uint8_t data)
+static int dsrtc_send(I2CSlave *i2c, uint8_t data)
{
- DS1338State *s = DS1338(i2c);
+ DSRTCState *s = DSRTC(i2c);
if (s->addr_byte) {
s->ptr = data & (NVRAM_SIZE - 1);
@@ -226,15 +226,15 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data)
}
s->nvram[s->ptr] = data;
if (s->ptr <= R_YEAR) {
- ds1338_update(s);
+ dsrtc_update(s);
}
inc_regptr(s);
return 0;
}
-static void ds1338_reset(DeviceState *dev)
+static void dsrtc_reset(DeviceState *dev)
{
- DS1338State *s = DS1338(dev);
+ DSRTCState *s = DSRTC(dev);
/* The clock is running and synchronized with the host */
s->offset = 0;
@@ -244,28 +244,28 @@ static void ds1338_reset(DeviceState *dev)
s->addr_byte = false;
}
-static void ds1338_class_init(ObjectClass *klass, void *data)
+static void dsrtc_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
I2CSlaveClass *k = I2C_SLAVE_CLASS(klass);
- k->event = ds1338_event;
- k->recv = ds1338_recv;
- k->send = ds1338_send;
- dc->reset = ds1338_reset;
- dc->vmsd = &vmstate_ds1338;
+ k->event = dsrtc_event;
+ k->recv = dsrtc_recv;
+ k->send = dsrtc_send;
+ dc->reset = dsrtc_reset;
+ dc->vmsd = &vmstate_dsrtc;
}
-static const TypeInfo ds1338_info = {
- .name = TYPE_DS1338,
+static const TypeInfo dsrtc_info = {
+ .name = TYPE_DSRTC,
.parent = TYPE_I2C_SLAVE,
- .instance_size = sizeof(DS1338State),
- .class_init = ds1338_class_init,
+ .instance_size = sizeof(DSRTCState),
+ .class_init = dsrtc_class_init,
};
-static void ds1338_register_types(void)
+static void dsrtc_register_types(void)
{
- type_register_static(&ds1338_info);
+ type_register_static(&dsrtc_info);
}
-type_init(ds1338_register_types)
+type_init(dsrtc_register_types)
--
2.11.0
next prev parent reply other threads:[~2018-07-05 18:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 18:19 [Qemu-devel] [PATCH 00/14] Generalize Dallas/Maxim I2C RTC devices v3 Michael Davidsaver
2018-07-05 18:19 ` [Qemu-devel] [PATCH 01/14] tests: more thorough tests of ds1338 Michael Davidsaver
2018-07-17 15:28 ` Peter Maydell
2018-07-05 18:19 ` [Qemu-devel] [PATCH 02/14] timer: ds1338 use registerfields.h Michael Davidsaver
2018-07-06 1:35 ` David Gibson
2018-07-05 18:19 ` [Qemu-devel] [PATCH 03/14] timer: ds1338 persist 12-hour mode selection Michael Davidsaver
2018-07-06 3:39 ` David Gibson
2018-07-06 4:35 ` Michael Davidsaver
2018-07-07 17:59 ` Michael Davidsaver
2018-07-09 5:09 ` David Gibson
2018-07-05 18:19 ` [Qemu-devel] [PATCH 04/14] timer: ds1338 clarify HOUR handling Michael Davidsaver
2018-07-09 5:12 ` David Gibson
2018-07-05 18:19 ` [Qemu-devel] [PATCH 05/14] timer: ds1338 change write handling and fix wday_offset handling Michael Davidsaver
2018-07-16 4:25 ` David Gibson
2018-07-05 18:19 ` [Qemu-devel] [PATCH 06/14] tests: ds-rtc test 12 hour mode Michael Davidsaver
2018-07-07 17:49 ` [Qemu-devel] [PATCH v2 " Michael Davidsaver
2018-07-09 6:49 ` David Gibson
2018-07-05 18:19 ` [Qemu-devel] [PATCH 07/14] tests: ds-rtc test wday offset Michael Davidsaver
2018-07-07 17:50 ` [Qemu-devel] [PATCH v2 " Michael Davidsaver
2018-07-09 6:50 ` David Gibson
2018-07-05 18:19 ` Michael Davidsaver [this message]
2018-07-05 18:19 ` [Qemu-devel] [PATCH 09/14] timer: rename file ds1338.c -> ds-rtc.c Michael Davidsaver
2018-07-05 18:19 ` [Qemu-devel] [PATCH 10/14] timer: ds1338 remove vestige of un-modeled OSF Michael Davidsaver
2018-07-16 4:26 ` David Gibson
2018-07-05 18:19 ` [Qemu-devel] [PATCH 12/14] timer: ds-rtc handle CENTURY bit Michael Davidsaver
2018-07-16 9:43 ` David Gibson
2018-07-05 18:20 ` [Qemu-devel] [PATCH 13/14] timer: ds-rtc model ds1375 Michael Davidsaver
2018-07-16 9:44 ` David Gibson
2018-07-05 18:20 ` [Qemu-devel] [PATCH 14/14] tests: drop ds1338-test Michael Davidsaver
2018-07-17 15:23 ` Peter Maydell
[not found] ` <20180705182001.16537-12-mdavidsaver@gmail.com>
2018-07-16 9:19 ` [Qemu-devel] [PATCH 11/14] timer: generalize ds1338 David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705182001.16537-9-mdavidsaver@gmail.com \
--to=mdavidsaver@gmail.com \
--cc=barsamin@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).