qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
	qemu-devel@nongnu.org, berrange@redhat.com, jferlan@redhat.com,
	ben@skyportsystems.com
Subject: Re: [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs
Date: Thu, 5 Jul 2018 21:59:24 +0100	[thread overview]
Message-ID: <20180705205924.GQ1455@redhat.com> (raw)
In-Reply-To: <20180705200659-mutt-send-email-mst@kernel.org>

On Thu, Jul 05, 2018 at 08:10:15PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jul 05, 2018 at 05:43:43PM +0100, Richard W.M. Jones wrote:
> > On Thu, Jul 05, 2018 at 04:20:33PM +0200, Laszlo Ersek wrote:
> > > QEMU does the right thing. If other hypervisors don't do this -- while
> > > still taking and displaying the value in UUID / GUID textual format --,
> > > they are wrong. The VMGENID spec from Microsoft
> > > <http://go.microsoft.com/fwlink/?LinkId=260709> specifically mentions
> > > "GUID".
> > 
> > The MSFT spec does mention GUID, but it seems to me that it's only
> > using GUID as an incidental example -- ie. that you might use the VM
> > Generation ID to generate a GUID.  Outside that example it
> > consistently refers to the VM Gen ID as a 128-bit integer.  It also
> > says that it could be used as a "high entropy random data source",
> > which is not in fact true if it's a UUID.
> > 
> > It has to be said that after reading the spec again [the MSFT spec,
> > not qemu's spec] and what other hypervisors are doing, I'm not sure
> > qemu is doing the right thing here.
> > 
> > Rich.
> 
> So right now we have a "GUID" property.
> We could always add an alternative property for people who want
> to treat the ID as an integer. Would that address the issue?

TBH I'm fairly relaxed about this and I don't want to put in any
effort to change anything.  As Dan says later in the thread, no data
is ever lost in the transformation.

I have now written a "128 bit int" -> "GUID" mangler for virt-v2v's
VM Generation ID handling code, so I'm happy enough.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

  reply	other threads:[~2018-07-05 20:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 12:39 [Qemu-devel] Byte ordering of VM Generation ID in Windows VMs Richard W.M. Jones
2018-07-05 12:52 ` Richard W.M. Jones
2018-07-05 13:54   ` Michael S. Tsirkin
2018-07-05 14:11     ` Richard W.M. Jones
2018-07-09  7:36       ` Richard W.M. Jones
2018-07-09  9:05         ` Laszlo Ersek
2018-07-09  9:11           ` Richard W.M. Jones
2018-07-09 15:50         ` Richard W.M. Jones
2018-07-05 14:20   ` Laszlo Ersek
2018-07-05 16:43     ` Richard W.M. Jones
2018-07-05 17:10       ` Michael S. Tsirkin
2018-07-05 20:59         ` Richard W.M. Jones [this message]
2018-07-05 17:13       ` Daniel P. Berrangé
2018-07-05 17:15       ` Laszlo Ersek
2018-07-05 17:34         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705205924.GQ1455@redhat.com \
    --to=rjones@redhat.com \
    --cc=ben@skyportsystems.com \
    --cc=berrange@redhat.com \
    --cc=jferlan@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).