From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbGLo-0006t2-1g for qemu-devel@nongnu.org; Thu, 05 Jul 2018 22:20:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbGLk-00081v-Se for qemu-devel@nongnu.org; Thu, 05 Jul 2018 22:20:00 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33280 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fbGLk-00081I-Nz for qemu-devel@nongnu.org; Thu, 05 Jul 2018 22:19:56 -0400 Date: Fri, 6 Jul 2018 10:19:51 +0800 From: Peter Xu Message-ID: <20180706021951.GD23001@xz-mi> References: <20180705031755.3254-1-peterx@redhat.com> <20180705031755.3254-5-peterx@redhat.com> <20180705093144.GA22608@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180705093144.GA22608@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH for-3.0 4/9] tests: introduce migrate_postcopy_* helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Balamuruhan S Cc: qemu-devel@nongnu.org On Thu, Jul 05, 2018 at 03:01:44PM +0530, Balamuruhan S wrote: > On Thu, Jul 05, 2018 at 11:17:50AM +0800, Peter Xu wrote: > > Separate the old postcopy UNIX socket test into three steps, provide a > > helper for each step. With these helpers, we can do more compliated > > tests like postcopy recovery, while keep the codes shared. > > > > Signed-off-by: Peter Xu > > --- > > tests/migration-test.c | 38 +++++++++++++++++++++++++++----------- > > 1 file changed, 27 insertions(+), 11 deletions(-) > > > > diff --git a/tests/migration-test.c b/tests/migration-test.c > > index 3a85446f95..2155869b96 100644 > > --- a/tests/migration-test.c > > +++ b/tests/migration-test.c > > @@ -351,13 +351,19 @@ static void migrate(QTestState *who, const char *uri) > > qobject_unref(rsp); > > } > > > > -static void migrate_start_postcopy(QTestState *who) > > +static void migrate_postcopy_start(QTestState *from, QTestState *to) > > { > > QDict *rsp; > > > > - rsp = wait_command(who, "{ 'execute': 'migrate-start-postcopy' }"); > > + rsp = wait_command(from, "{ 'execute': 'migrate-start-postcopy' }"); > > g_assert(qdict_haskey(rsp, "return")); > > qobject_unref(rsp); > > + > > + if (!got_stop) { > > + qtest_qmp_eventwait(from, "STOP"); > > + } > > + > > + qtest_qmp_eventwait(to, "RESUME"); > > } > > > > static void test_migrate_start(QTestState **from, QTestState **to, > > @@ -505,7 +511,8 @@ static void test_deprecated(void) > > qtest_quit(from); > > } > > > > -static void test_postcopy(void) > > +static void migrate_postcopy_prepare(QTestState **from_ptr, > > + QTestState **to_ptr) > > if we have uri as one of the configurable argument, it would be still > better, so that in future we can call migrate_postcopy_prepare() with > any different uri. Yes, though we'd better have a first user of it. Now postcopy only covers unix socket test. We don't have a large matrix yet. We can add that when we start to add more complicated tests for postcopy. Thanks, -- Peter Xu